Implement CallAsConstructor method for Object in the API

test/cctest/test-api.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 6726 matching lines @@
   Local<v8::FunctionTemplate> templ = v8::FunctionTemplate::New();
   templ->SetClassName(v8_str("Fun"));
   Local<Function> cons = templ->GetFunction();
   context->Global()->Set(v8_str("Fun"), cons);
   Local<v8::Object> inst = cons->NewInstance();
   i::Handle<i::JSObject> obj = v8::Utils::OpenHandle(*inst);
   Local<Value> value = CompileRun("(new Fun()).constructor === Fun");
   CHECK(value->BooleanValue());
 }
 
+
+static Handle<Value> ConstructorCallback(const Arguments& args) {
+  ApiTestFuzzer::Fuzz();
+  if (args[0]->IsInt32()) {
+    Local<Object> This;
+
+    if (args.IsConstructCall()) {
+      Local<Object> Holder = args.Holder();
+      This = Object::New();
+      Local<Value> proto = Holder->GetPrototype();
+      if (proto->IsObject())

[Mads Ager (chromium), 2011/04/28 12:14:42]

Use braces around if bodies or make this a one-liner.

+        This->SetPrototype(proto);
+    } else {
+      This = args.This();
+    }
+
+    This->Set(v8_str("a"), v8_num(args[0]->Int32Value()));
+    return This;
+  }
+
+  return args[0];
+}
+
+
+THREADED_TEST(ConstructorForObject) {
+  v8::HandleScope handle_scope;
+  LocalContext context;
+  Local<ObjectTemplate> instance_template = ObjectTemplate::New();
+  instance_template->SetCallAsFunctionHandler(ConstructorCallback);
+  Local<Object> instance = instance_template->NewInstance();
+
+  context->Global()->Set(v8_str("obj"), instance);
+  Local<Value> value1 =
+    CompileRun("(function() { var o = new obj(28); return o.a; })()");
+  CHECK_EQ(28, value1->Int32Value());
+
+  Local<Value> args[] = { v8_num(29) };

[Mads Ager (chromium), 2011/04/28 12:14:42]

Please add more testing. Test calling on a random object which does not have a
call as function handler. Test exceptions thrown in the construct callback.

+  Local<Object> object = instance->NewInstance(1, args);
+  Local<Value> value2 = object->Get(v8_str("a"));
+  CHECK_EQ(29, value2->Int32Value());
+}
+
+
 THREADED_TEST(FunctionDescriptorException) {
   v8::HandleScope handle_scope;
   LocalContext context;
   Local<v8::FunctionTemplate> templ = v8::FunctionTemplate::New();
   templ->SetClassName(v8_str("Fun"));
   Local<Function> cons = templ->GetFunction();
   context->Global()->Set(v8_str("Fun"), cons);
   Local<Value> value = CompileRun(
     "function test() {"
     "  try {"
@@ skipping 7259 matching lines @@
   { // Check that query wins on disagreement.
     Handle<ObjectTemplate> templ = ObjectTemplate::New();
     templ->SetNamedPropertyHandler(HasOwnPropertyNamedPropertyGetter,
                                    0,
                                    HasOwnPropertyNamedPropertyQuery2);
     Handle<Object> instance = templ->NewInstance();
     CHECK(!instance->HasOwnProperty(v8_str("foo")));
     CHECK(instance->HasOwnProperty(v8_str("bar")));
   }
 }