Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: src/array.js

Issue 6902104: Don't exchange null and undefined with the global object in function.prototype.{call, apply} for ... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/ia32/builtins-ia32.cc » ('j') | src/ia32/builtins-ia32.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/array.js
===================================================================
--- src/array.js (revision 7676)
+++ src/array.js (working copy)
@@ -375,6 +375,10 @@
function ArrayJoin(separator) {
+ if (IS_NULL_OR_UNDEFINED(this)) {
+ throw MakeTypeError("obj_ctor_property_non_object", ["Array.join"]);
+ }
+
if (IS_UNDEFINED(separator)) {
separator = ',';
} else if (!IS_STRING(separator)) {
@@ -391,6 +395,10 @@
// Removes the last element from the array and returns it. See
// ECMA-262, section 15.4.4.6.
function ArrayPop() {
+ if (IS_NULL_OR_UNDEFINED(this)) {
+ throw MakeTypeError("obj_ctor_property_non_object", ["Array.pop"]);
+ }
+
var n = TO_UINT32(this.length);
if (n == 0) {
this.length = n;
@@ -407,6 +415,9 @@
// Appends the arguments to the end of the array and returns the new
// length of the array. See ECMA-262, section 15.4.4.7.
function ArrayPush() {
+ if (IS_NULL_OR_UNDEFINED(this)) {
+ throw MakeTypeError("obj_ctor_property_non_object", ["Array.push"]);
+ }
var n = TO_UINT32(this.length);
var m = %_ArgumentsLength();
for (var i = 0; i < m; i++) {
@@ -418,6 +429,9 @@
function ArrayConcat(arg1) { // length == 1
+ if (IS_NULL_OR_UNDEFINED(this)) {
+ throw MakeTypeError("obj_ctor_property_non_object", ["Array.concat"]);
+ }
var arg_count = %_ArgumentsLength();
var arrays = new InternalArray(1 + arg_count);
arrays[0] = this;
@@ -474,6 +488,10 @@
function ArrayReverse() {
+ if (IS_NULL_OR_UNDEFINED(this)) {
+ throw MakeTypeError("obj_ctor_property_non_object", ["Array.reverse"]);
+ }
+
var j = TO_UINT32(this.length) - 1;
if (UseSparseVariant(this, j, IS_ARRAY(this))) {
@@ -505,6 +523,10 @@
function ArrayShift() {
+ if (IS_NULL_OR_UNDEFINED(this)) {
+ throw MakeTypeError("obj_ctor_property_non_object", ["Array.shift"]);
+ }
+
var len = TO_UINT32(this.length);
if (len === 0) {
@@ -526,6 +548,10 @@
function ArrayUnshift(arg1) { // length == 1
+ if (IS_NULL_OR_UNDEFINED(this)) {
+ throw MakeTypeError("obj_ctor_property_non_object", ["Array.unshift"]);
+ }
+
var len = TO_UINT32(this.length);
var num_arguments = %_ArgumentsLength();
@@ -545,6 +571,9 @@
function ArraySlice(start, end) {
+ if (IS_NULL_OR_UNDEFINED(this)) {
+ throw MakeTypeError("obj_ctor_property_non_object", ["Array.slice"]);
+ }
var len = TO_UINT32(this.length);
var start_i = TO_INTEGER(start);
var end_i = len;
@@ -582,6 +611,9 @@
function ArraySplice(start, delete_count) {
+ if (IS_NULL_OR_UNDEFINED(this)) {
+ throw MakeTypeError("obj_ctor_property_non_object", ["Array.splice"]);
+ }
var num_arguments = %_ArgumentsLength();
var len = TO_UINT32(this.length);
@@ -653,6 +685,10 @@
function ArraySort(comparefn) {
+ if (IS_NULL_OR_UNDEFINED(this)) {
+ throw MakeTypeError("obj_ctor_property_non_object", ["Array.sort"]);
+ }
+
// In-place QuickSort algorithm.
// For short (length <= 22) arrays, insertion sort is used for efficiency.
@@ -914,6 +950,10 @@
// preserving the semantics, since the calls to the receiver function can add
// or delete elements from the array.
function ArrayFilter(f, receiver) {
+ if (IS_NULL_OR_UNDEFINED(this)) {
+ throw MakeTypeError("obj_ctor_property_non_object", ["Array.filter"]);
+ }
+
if (!IS_FUNCTION(f)) {
throw MakeTypeError('called_non_callable', [ f ]);
}
@@ -935,6 +975,10 @@
function ArrayForEach(f, receiver) {
+ if (IS_NULL_OR_UNDEFINED(this)) {
+ throw MakeTypeError("obj_ctor_property_non_object", ["Array.forEach"]);
+ }
+
if (!IS_FUNCTION(f)) {
throw MakeTypeError('called_non_callable', [ f ]);
}
@@ -953,6 +997,10 @@
// Executes the function once for each element present in the
// array until it finds one where callback returns true.
function ArraySome(f, receiver) {
+ if (IS_NULL_OR_UNDEFINED(this)) {
+ throw MakeTypeError("obj_ctor_property_non_object", ["Array.some"]);
+ }
+
if (!IS_FUNCTION(f)) {
throw MakeTypeError('called_non_callable', [ f ]);
}
@@ -970,6 +1018,9 @@
function ArrayEvery(f, receiver) {
+ if (IS_NULL_OR_UNDEFINED(this)) {
+ throw MakeTypeError("obj_ctor_property_non_object", ["Array.every"]);
+ }
if (!IS_FUNCTION(f)) {
throw MakeTypeError('called_non_callable', [ f ]);
}
@@ -986,6 +1037,10 @@
}
function ArrayMap(f, receiver) {
+ if (IS_NULL_OR_UNDEFINED(this)) {
+ throw MakeTypeError("obj_ctor_property_non_object", ["Array.map"]);
+ }
+
if (!IS_FUNCTION(f)) {
throw MakeTypeError('called_non_callable', [ f ]);
}
@@ -1006,6 +1061,9 @@
function ArrayIndexOf(element, index) {
+ if (IS_NULL_OR_UNDEFINED(this)) {
+ throw MakeTypeError("obj_ctor_property_non_object", ["Array.indexOf"]);
+ }
var length = TO_UINT32(this.length);
if (length == 0) return -1;
if (IS_UNDEFINED(index)) {
@@ -1063,6 +1121,10 @@
function ArrayLastIndexOf(element, index) {
+ if (IS_NULL_OR_UNDEFINED(this)) {
+ throw MakeTypeError("obj_ctor_property_non_object", ["Array.lastIndexOf"]);
+ }
+
var length = TO_UINT32(this.length);
if (length == 0) return -1;
if (%_ArgumentsLength() < 2) {
@@ -1116,6 +1178,9 @@
function ArrayReduce(callback, current) {
+ if (IS_NULL_OR_UNDEFINED(this)) {
+ throw MakeTypeError("obj_ctor_property_non_object", ["Array.reduce"]);
+ }
if (!IS_FUNCTION(callback)) {
throw MakeTypeError('called_non_callable', [callback]);
}
@@ -1145,6 +1210,10 @@
}
function ArrayReduceRight(callback, current) {
+ if (IS_NULL_OR_UNDEFINED(this)) {
+ throw MakeTypeError("obj_ctor_property_non_object", ["Array.reduceRight"]);
+ }
+
if (!IS_FUNCTION(callback)) {
throw MakeTypeError('called_non_callable', [callback]);
}
« no previous file with comments | « no previous file | src/ia32/builtins-ia32.cc » ('j') | src/ia32/builtins-ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698