Don't exchange null and undefined with the global object in function.prototype.{call, apply} for ...

src/array.js

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 357 matching lines @@
 
 function ArrayToLocaleString() {
   if (!IS_ARRAY(this)) {
     throw new $TypeError('Array.prototype.toString is not generic');
   }
   return Join(this, this.length, ',', ConvertToLocaleString);
 }
 
 
 function ArrayJoin(separator) {
+  if (IS_NULL_OR_UNDEFINED(this)) {

[Lasse Reichstein, 2011/04/28 10:44:38]

Is this correct behavior for an undetectable object?
(Can we create an undetectable string and/or object for testing?)

[Lasse Reichstein, 2011/04/28 10:50:01]

Just checked Firefox 4. It does not throw when passing document.all (an
undetectable object) as receiver.

[MarkM, 2011/04/28 15:40:45]

Do we have any undetectable objects other that document.all?

Firefox's strategy for handling document.all differs from WebKits. WebKit treats
the value as a special kind of value, whereas FF treats the lookup of the "all"
property of document as a special context sensitive kind of lookup. The lookup
is sensitive to the syntactic context from which it is looked up, but once
looked up yields either a normal value or a normal undefined. AFAIK, FF does not
have special undetectable objects as first class values.

See https://bugzilla.mozilla.org/show_bug.cgi?id=521670#c6

[Rico, 2011/05/03 08:47:20]

Added checks for the undetectable object in all cases

+    throw MakeTypeError("obj_ctor_property_non_object", ["Array.join"]);

[Lasse Reichstein, 2011/04/28 10:44:38]

The name shouldn't be "Array.prototype.join"?

[MarkM, 2011/04/28 18:58:21]

For all these generics, I wonder about the string "obj_ctor_property_non_object"
as not reflecting what the actual error is. After all

    > typeof [].map.call("foo", function(c,i,a) { return a; })[0]
    object


already works, as it should, by coercing its this to an object as specified by
ToObject. This shows that the problem isn't that the this is a "non_object" but
that it's null or undefined. (Or, given document.all, perhaps "indistinguishable
from null or undefined")

[Rico, 2011/05/03 08:47:20]

Changed

[Rico, 2011/05/03 08:47:20]

Changed to "FUNCTIONNAME called on null or undefined"

+  }
+
   if (IS_UNDEFINED(separator)) {
     separator = ',';
   } else if (!IS_STRING(separator)) {
     separator = NonStringToString(separator);
   }
 
   var result = %_FastAsciiArrayJoin(this, separator);
   if (!IS_UNDEFINED(result)) return result;
 
   return Join(this, TO_UINT32(this.length), separator, ConvertToString);
 }
 
 
 // Removes the last element from the array and returns it. See
 // ECMA-262, section 15.4.4.6.
 function ArrayPop() {
+  if (IS_NULL_OR_UNDEFINED(this)) {
+    throw MakeTypeError("obj_ctor_property_non_object", ["Array.pop"]);
+  }
+
   var n = TO_UINT32(this.length);
   if (n == 0) {
     this.length = n;
     return;
   }
   n--;
   var value = this[n];
   this.length = n;
   delete this[n];
   return value;
 }
 
 
 // Appends the arguments to the end of the array and returns the new
 // length of the array. See ECMA-262, section 15.4.4.7.
 function ArrayPush() {
+  if (IS_NULL_OR_UNDEFINED(this)) {
+    throw MakeTypeError("obj_ctor_property_non_object", ["Array.push"]);
+  }
+
   var n = TO_UINT32(this.length);
   var m = %_ArgumentsLength();
   for (var i = 0; i < m; i++) {
     this[i+n] = %_Arguments(i);
   }
   this.length = n + m;
   return this.length;
 }
 
 
 function ArrayConcat(arg1) {  // length == 1
+  if (IS_NULL_OR_UNDEFINED(this)) {
+    throw MakeTypeError("obj_ctor_property_non_object", ["Array.concat"]);
+  }
+
   var arg_count = %_ArgumentsLength();
   var arrays = new InternalArray(1 + arg_count);
   arrays[0] = this;
   for (var i = 0; i < arg_count; i++) {
     arrays[i + 1] = %_Arguments(i);
   }
 
   return %ArrayConcat(arrays);
 }
 
@@ skipping 36 matching lines @@
       if (!IS_UNDEFINED(current_j) || high in array) {
         array[low] = current_j;
         delete array[high];
       }
     }
   }
 }
 
 
 function ArrayReverse() {
+  if (IS_NULL_OR_UNDEFINED(this)) {
+    throw MakeTypeError("obj_ctor_property_non_object", ["Array.reverse"]);
+  }
+
   var j = TO_UINT32(this.length) - 1;
 
   if (UseSparseVariant(this, j, IS_ARRAY(this))) {
     SparseReverse(this, j+1);
     return this;
   }
 
   for (var i = 0; i < j; i++, j--) {
     var current_i = this[i];
     if (!IS_UNDEFINED(current_i) || i in this) {
@@ skipping 11 matching lines @@
         this[i] = current_j;
         delete this[j];
       }
     }
   }
   return this;
 }
 
 
 function ArrayShift() {
+  if (IS_NULL_OR_UNDEFINED(this)) {
+    throw MakeTypeError("obj_ctor_property_non_object", ["Array.shift"]);
+  }
+
   var len = TO_UINT32(this.length);
 
   if (len === 0) {
     this.length = 0;
     return;
   }
 
   var first = this[0];
 
   if (IS_ARRAY(this))
     SmartMove(this, 0, 1, len, 0);
   else
     SimpleMove(this, 0, 1, len, 0);
 
   this.length = len - 1;
 
   return first;
 }
 
 
 function ArrayUnshift(arg1) {  // length == 1
+  if (IS_NULL_OR_UNDEFINED(this)) {
+    throw MakeTypeError("obj_ctor_property_non_object", ["Array.unshift"]);
+  }
+
   var len = TO_UINT32(this.length);
   var num_arguments = %_ArgumentsLength();
 
   if (IS_ARRAY(this))
     SmartMove(this, 0, 0, len, num_arguments);
   else
     SimpleMove(this, 0, 0, len, num_arguments);
 
   for (var i = 0; i < num_arguments; i++) {
     this[i] = %_Arguments(i);
   }
 
   this.length = len + num_arguments;
 
   return len + num_arguments;
 }
 
 
 function ArraySlice(start, end) {
+  if (IS_NULL_OR_UNDEFINED(this)) {
+    throw MakeTypeError("obj_ctor_property_non_object", ["Array.slice"]);
+  }
+
   var len = TO_UINT32(this.length);
   var start_i = TO_INTEGER(start);
   var end_i = len;
 
   if (end !== void 0) end_i = TO_INTEGER(end);
 
   if (start_i < 0) {
     start_i += len;
     if (start_i < 0) start_i = 0;
   } else {
@@ skipping 17 matching lines @@
     SimpleSlice(this, start_i, end_i - start_i, len, result);
   }
 
   result.length = end_i - start_i;
 
   return result;
 }
 
 
 function ArraySplice(start, delete_count) {
+  if (IS_NULL_OR_UNDEFINED(this)) {
+    throw MakeTypeError("obj_ctor_property_non_object", ["Array.splice"]);
+  }
+
   var num_arguments = %_ArgumentsLength();
 
   var len = TO_UINT32(this.length);
   var start_i = TO_INTEGER(start);
 
   if (start_i < 0) {
     start_i += len;
     if (start_i < 0) start_i = 0;
   } else {
     if (start_i > len) start_i = len;
@@ skipping 51 matching lines @@
     this[i++] = %_Arguments(arguments_index++);
   }
   this.length = len - del_count + num_additional_args;
 
   // Return the deleted elements.
   return deleted_elements;
 }
 
 
 function ArraySort(comparefn) {
+  if (IS_NULL_OR_UNDEFINED(this)) {
+    throw MakeTypeError("obj_ctor_property_non_object", ["Array.sort"]);
+  }
+
   // In-place QuickSort algorithm.
   // For short (length <= 22) arrays, insertion sort is used for efficiency.
 
   if (!IS_FUNCTION(comparefn)) {
     comparefn = function (x, y) {
       if (x === y) return 0;
       if (%_IsSmi(x) && %_IsSmi(y)) {
         return %SmiLexicographicCompare(x, y);
       }
       x = ToString(x);
@@ skipping 241 matching lines @@
   }
 
   return this;
 }
 
 
 // The following functions cannot be made efficient on sparse arrays while
 // preserving the semantics, since the calls to the receiver function can add
 // or delete elements from the array.
 function ArrayFilter(f, receiver) {
+  if (IS_NULL_OR_UNDEFINED(this)) {
+    throw MakeTypeError("obj_ctor_property_non_object", ["Array.filter"]);
+  }
+
   if (!IS_FUNCTION(f)) {
     throw MakeTypeError('called_non_callable', [ f ]);
   }
   // Pull out the length so that modifications to the length in the
   // loop will not affect the looping.
   var length = this.length;
   var result = [];
   var result_length = 0;
   for (var i = 0; i < length; i++) {
     var current = this[i];
     if (!IS_UNDEFINED(current) || i in this) {
       if (f.call(receiver, current, i, this)) {
         result[result_length++] = current;
       }
     }
   }
   return result;
 }
 
 
 function ArrayForEach(f, receiver) {
+  if (IS_NULL_OR_UNDEFINED(this)) {
+    throw MakeTypeError("obj_ctor_property_non_object", ["Array.forEach"]);
+  }
+
   if (!IS_FUNCTION(f)) {
     throw MakeTypeError('called_non_callable', [ f ]);
   }
   // Pull out the length so that modifications to the length in the
   // loop will not affect the looping.
   var length =  TO_UINT32(this.length);
   for (var i = 0; i < length; i++) {
     var current = this[i];
     if (!IS_UNDEFINED(current) || i in this) {
       f.call(receiver, current, i, this);

[Lasse Reichstein, 2011/04/28 10:44:38]

While you are here, make this use %_CallFunction (and similar for the other that
calls).
You may have to handle the receiver being null/undefined too :)

[Rico, 2011/05/03 08:47:20]

I don't want to make this cl even larger, lets do this in another one

     }
   }
 }
 
 
 // Executes the function once for each element present in the
 // array until it finds one where callback returns true.
 function ArraySome(f, receiver) {
+  if (IS_NULL_OR_UNDEFINED(this)) {
+    throw MakeTypeError("obj_ctor_property_non_object", ["Array.some"]);
+  }
+
   if (!IS_FUNCTION(f)) {
     throw MakeTypeError('called_non_callable', [ f ]);
   }
   // Pull out the length so that modifications to the length in the
   // loop will not affect the looping.
   var length = TO_UINT32(this.length);
   for (var i = 0; i < length; i++) {
     var current = this[i];
     if (!IS_UNDEFINED(current) || i in this) {
       if (f.call(receiver, current, i, this)) return true;
     }
   }
   return false;
 }
 
 
 function ArrayEvery(f, receiver) {
+  if (IS_NULL_OR_UNDEFINED(this)) {
+    throw MakeTypeError("obj_ctor_property_non_object", ["Array.every"]);
+  }
+
   if (!IS_FUNCTION(f)) {
     throw MakeTypeError('called_non_callable', [ f ]);
   }
   // Pull out the length so that modifications to the length in the
   // loop will not affect the looping.
   var length = TO_UINT32(this.length);
   for (var i = 0; i < length; i++) {
     var current = this[i];
     if (!IS_UNDEFINED(current) || i in this) {
       if (!f.call(receiver, current, i, this)) return false;
     }
   }
   return true;
 }
 
 function ArrayMap(f, receiver) {
+  if (IS_NULL_OR_UNDEFINED(this)) {
+    throw MakeTypeError("obj_ctor_property_non_object", ["Array.map"]);
+  }
+
   if (!IS_FUNCTION(f)) {
     throw MakeTypeError('called_non_callable', [ f ]);
   }
   // Pull out the length so that modifications to the length in the
   // loop will not affect the looping.
   var length = TO_UINT32(this.length);
   var result = new $Array();
   var accumulator = new InternalArray(length);
   for (var i = 0; i < length; i++) {
     var current = this[i];
     if (!IS_UNDEFINED(current) || i in this) {
       accumulator[i] = f.call(receiver, current, i, this);
     }
   }
   %MoveArrayContents(accumulator, result);
   return result;
 }
 
 
 function ArrayIndexOf(element, index) {
+  if (IS_NULL_OR_UNDEFINED(this)) {
+    throw MakeTypeError("obj_ctor_property_non_object", ["Array.indexOf"]);
+  }
+
   var length = TO_UINT32(this.length);
   if (length == 0) return -1;
   if (IS_UNDEFINED(index)) {
     index = 0;
   } else {
     index = TO_INTEGER(index);
     // If index is negative, index from the end of the array.
     if (index < 0) {
       index = length + index;
       // If index is still negative, search the entire array.
@@ skipping 37 matching lines @@
   for (var i = min; i < max; i++) {
     if (IS_UNDEFINED(this[i]) && i in this) {
       return i;
     }
   }
   return -1;
 }
 
 
 function ArrayLastIndexOf(element, index) {
+  if (IS_NULL_OR_UNDEFINED(this)) {
+    throw MakeTypeError("obj_ctor_property_non_object", ["Array.lastIndexOf"]);
+  }
+
   var length = TO_UINT32(this.length);
   if (length == 0) return -1;
   if (%_ArgumentsLength() < 2) {
     index = length - 1;
   } else {
     index = TO_INTEGER(index);
     // If index is negative, index from end of the array.
     if (index < 0) index += length;
     // If index is still negative, do not search the array.
     if (index < 0) return -1;
@@ skipping 33 matching lines @@
   for (var i = max; i >= min; i--) {
     if (IS_UNDEFINED(this[i]) && i in this) {
       return i;
     }
   }
   return -1;
 }
 
 
 function ArrayReduce(callback, current) {
+  if (IS_NULL_OR_UNDEFINED(this)) {
+    throw MakeTypeError("obj_ctor_property_non_object", ["Array.reduce"]);
+  }
+
   if (!IS_FUNCTION(callback)) {
     throw MakeTypeError('called_non_callable', [callback]);
   }
   // Pull out the length so that modifications to the length in the
   // loop will not affect the looping.
   var length = this.length;
   var i = 0;
 
   find_initial: if (%_ArgumentsLength() < 2) {
     for (; i < length; i++) {
       current = this[i];
       if (!IS_UNDEFINED(current) || i in this) {
         i++;
         break find_initial;
       }
     }
     throw MakeTypeError('reduce_no_initial', []);
   }
 
   for (; i < length; i++) {
     var element = this[i];
     if (!IS_UNDEFINED(element) || i in this) {
       current = callback.call(null, current, element, i, this);
     }
   }
   return current;
 }
 
 function ArrayReduceRight(callback, current) {
+  if (IS_NULL_OR_UNDEFINED(this)) {
+    throw MakeTypeError("obj_ctor_property_non_object", ["Array.reduceRight"]);
+  }
+
   if (!IS_FUNCTION(callback)) {
     throw MakeTypeError('called_non_callable', [callback]);
   }
   var i = this.length - 1;
 
   find_initial: if (%_ArgumentsLength() < 2) {
     for (; i >= 0; i--) {
       current = this[i];
       if (!IS_UNDEFINED(current) || i in this) {
         i--;
@@ skipping 82 matching lines @@
   InternalArray.prototype.join = getFunction("join", ArrayJoin);
   InternalArray.prototype.pop = getFunction("pop", ArrayPop);
   InternalArray.prototype.push = getFunction("push", ArrayPush);
   InternalArray.prototype.toString = function() {
     return "Internal Array, length " + this.length;
   };
 }
 
 
 SetupArray();