chrome/test/live_sync/single_client_live_passwords_sync_test.cc - Issue 6902101: Refactor sync passphrase setup flow and fix passphrase tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/live_sync/single_client_live_passwords_sync_test.cc

Issue 6902101: Refactor sync passphrase setup flow and fix passphrase tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: de Morgan's law simplification. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/sync/js_sync_manager_observer_unittest.cc ('K') | « chrome/test/live_sync/live_passwords_sync_test.cc ('k') | chrome/test/live_sync/two_client_live_passwords_sync_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/password_manager/password_form_data.h"	5 #include "chrome/browser/password_manager/password_form_data.h"

6 #include "chrome/browser/sync/profile_sync_service_harness.h"	6 #include "chrome/browser/sync/profile_sync_service_harness.h"

7 #include "chrome/test/live_sync/live_passwords_sync_test.h"	7 #include "chrome/test/live_sync/live_passwords_sync_test.h"

8	8

9 using webkit_glue::PasswordForm;	9 using webkit_glue::PasswordForm;

10	10

11 // TODO(rsimha): See http://crbug.com/78840.	11 IN_PROC_BROWSER_TEST_F(SingleClientLivePasswordsSyncTest, Sanity) {

12 IN_PROC_BROWSER_TEST_F(SingleClientLivePasswordsSyncTest, FLAKY_Sanity) {

13 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";	12 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";

14	13

15 PasswordForm form = CreateTestPasswordForm(0);	14 PasswordForm form = CreateTestPasswordForm(0);

16 AddLogin(GetVerifierPasswordStore(), form);	15 AddLogin(GetVerifierPasswordStore(), form);

17	16

18 std::vector<PasswordForm> verifier_forms;	17 std::vector<PasswordForm> verifier_forms;

19 GetLogins(GetVerifierPasswordStore(), verifier_forms);	18 GetLogins(GetVerifierPasswordStore(), verifier_forms);

20 EXPECT_EQ(1U, verifier_forms.size());	19 EXPECT_EQ(1U, verifier_forms.size());

21	20

22 AddLogin(GetPasswordStore(0), form);	21 AddLogin(GetPasswordStore(0), form);

23 ASSERT_TRUE(GetClient(0)->AwaitSyncCycleCompletion("Added a login."));	22 ASSERT_TRUE(GetClient(0)->AwaitSyncCycleCompletion("Added a login."));

24	23

25 std::vector<PasswordForm> forms0;	24 std::vector<PasswordForm> forms0;

26 GetLogins(GetPasswordStore(0), forms0);	25 GetLogins(GetPasswordStore(0), forms0);

27 ASSERT_TRUE(ContainsSamePasswordForms(verifier_forms, forms0));	26 ASSERT_TRUE(ContainsSamePasswordForms(verifier_forms, forms0));

28 }	27 }

OLD	NEW