Refactor sync passphrase setup flow and fix passphrase tests

chrome/browser/sync/glue/sync_backend_host.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_GLUE_SYNC_BACKEND_HOST_H_
 #define CHROME_BROWSER_SYNC_GLUE_SYNC_BACKEND_HOST_H_
 #pragma once
 
 #include <map>
 #include <string>
@@ skipping 74 matching lines @@
   // changed in another synced client.  if
   // |passphrase_required_for_decryption| is false, the passphrase is
   // required only for encryption.
   virtual void OnPassphraseRequired(bool for_decryption) = 0;
 
   // Called when the passphrase provided by the user is
   // accepted. After this is called, updates to sensitive nodes are
   // encrypted using the accepted passphrase.
   virtual void OnPassphraseAccepted() = 0;
 
+  // The syncer has attempted to set a passphrase, but failed to decrypt the
+  // cryptographer's pending keys. A new passphrase is required.
+  virtual void OnPassphraseFailed() = 0;

[tim (not reviewing), 2011/04/28 17:13:53]

This is what OnPassphraseRequired is for above...  we already added a bool to
that method to distinguish for_decryption.  Is there now a third state?

[Raghu Simha, 2011/04/28 17:44:21]

ProfileSyncServiceHarness::OnStateChanged is called when
SyncFrontend::OnPassphraseAccepted() is triggered by both,
Core::NotifyPassphraseRequired() and by Core::NotifyPassphraseFailed(). The crux
of this patch is that we need a way to differentiate between the two. This is
because in the first case (required), forward progress is possible, while in the
latter case (failed), forward progress is impossible and we must exit early from
AwaitStatusChangeWithTimeout.

+
   virtual void OnEncryptionComplete(
       const syncable::ModelTypeSet& encrypted_types) = 0;
 
   // Called to perform migration of |types|.
   virtual void OnMigrationNeededForTypes(
       const syncable::ModelTypeSet& types) = 0;
 
  protected:
   // Don't delete through SyncFrontend interface.
   virtual ~SyncFrontend() {
@@ skipping 540 matching lines @@
 
   // Whether we've processed the initialization complete callback.
   bool syncapi_initialized_;
 
   DISALLOW_COPY_AND_ASSIGN(SyncBackendHost);
 };
 
 }  // namespace browser_sync
 
 #endif  // CHROME_BROWSER_SYNC_GLUE_SYNC_BACKEND_HOST_H_