wm: Update a lot of code to use structs from geometry.h.

wm: Update a lot of code to use structs from geometry.h.

I'm updating most of the code here, with a few exceptions:
- Compositor (I'll do this in a separate change)
- deprecated Window::MoveClient() and MoveComposited()
  methods
- LayoutManager (I have a simplified rewrite of this
  in-progress for http://crosbug.com/13963)

Most of this change is completely mechanical, but I'm also
simplifying how we handle moving override-redirect windows'
compositing actors to the correct place onscreen and showing,
hiding, and restacking them: instead of doing this manually
in the WindowManager class, it's done in
Window::HandleConfigureNotify() and friends.

BUG=chromium-os:1822
TEST=ran existing tests

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=81f9db9

[Daniel Erat, 2011-05-02 16:53:19]

Sorry for the hugeness of this change.  I'm hoping that it's repetitive enough
that it won't take more than a few minutes to go through (assuming that you
don't fall asleep out of boredom while looking at it). :-/

http://codereview.chromium.org/6902072/diff/7001/window.cc
File window.cc (right):

http://codereview.chromium.org/6902072/diff/7001/window.cc#newcode973
window.cc:973: while (above_xid) {
This is just lifted from WindowManager.

[Daniel Erat, 2011-05-02 16:55:55]

Whoops, meant to make you the lucky recipient of this. :-P

[Greg Spencer (Chromium), 2011-05-02 17:03:25]

LGTM. You're right.  It was boring. :)

I'll just take that as punishment for being tardy on my last review.