Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Issue 6902069: Increase warning level to 4 on Visual Studio (Closed)

Created:
9 years, 8 months ago by M-A Ruel
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Increase warning level to 4 on Visual Studio This requires disabling most /W4 warnings so the patch doesn't get too large. I still fixed a few bugs so I didn't have to disable some more serious warnings. Most of these warnings are already enabled on gcc so it's mostly windows-specific code that is affected. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83840

Patch Set 1 #

Patch Set 2 : Fixed remaining issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M build/common.gypi View 1 2 chunks +10 lines, -3 lines 0 comments Download
M chrome/test/selenium/selenium_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/third_party/nss/ssl.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M views/controls/table/native_table_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M views/view_win.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_windowless_test.cc View 1 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
9 years, 7 months ago (2011-05-02 13:46:04 UTC) #1
nsylvain
LGTM
9 years, 7 months ago (2011-05-02 19:48:54 UTC) #2
commit-bot: I haz the power
Presubmit check for 6902069-2001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 7 months ago (2011-05-03 00:38:16 UTC) #3
commit-bot: I haz the power
Presubmit check for 6902069-2001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 7 months ago (2011-05-03 00:48:46 UTC) #4
rvargas (doing something else)
LGTM
9 years, 7 months ago (2011-05-03 01:04:56 UTC) #5
commit-bot: I haz the power
9 years, 7 months ago (2011-05-03 02:04:14 UTC) #6
Change committed as 83840

Powered by Google App Engine
This is Rietveld 408576698