Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6902066: Add AST ID to RelocInfo for type-recording ICs. Changes 7644 and 7632, combined. (Closed)

Created:
9 years, 8 months ago by William Hesse
Modified:
9 years, 7 months ago
Reviewers:
Rico
CC:
v8-dev
Visibility:
Public.

Description

Add AST ID to RelocInfo for type-recording ICs. Changes 7644 and 7632, combined. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7694

Patch Set 1 #

Patch Set 2 : Fix an issue where a switch statement label ID could be used for both a load IC and a compare IC. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+650 lines, -388 lines) Patch
M src/arm/assembler-arm.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 2 chunks +9 lines, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 1 32 chunks +127 lines, -98 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 3 chunks +11 lines, -3 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 2 chunks +28 lines, -4 lines 0 comments Download
M src/assembler.h View 8 chunks +28 lines, -14 lines 0 comments Download
M src/assembler.cc View 16 chunks +198 lines, -84 lines 0 comments Download
M src/ast.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/ast.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/disassembler.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/full-codegen.h View 3 chunks +10 lines, -5 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/assembler-ia32.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 2 chunks +7 lines, -3 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 29 chunks +44 lines, -33 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/type-info.h View 2 chunks +18 lines, -18 lines 0 comments Download
M src/type-info.cc View 1 16 chunks +58 lines, -70 lines 0 comments Download
M src/x64/assembler-x64.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 1 chunk +8 lines, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 29 chunks +45 lines, -33 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M test/cctest/test-debug.cc View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
William Hesse
Patch set 1 is just changes 7644 and 7632. Patch set 2 adds the fix ...
9 years, 8 months ago (2011-04-27 14:47:49 UTC) #1
Rico
9 years, 8 months ago (2011-04-27 14:54:49 UTC) #2 
Patch set 2 LGTM
Rubberstamp LGTM on the rest

Powered by Google App Engine
This is Rietveld 408576698