Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 6902064: Fix https://m.gmail.com/ and https://m.googlemail.com/, which don't return a (Closed)

Created:
9 years, 8 months ago by Chris Evans
Modified:
9 years, 6 months ago
Reviewers:
agl, abarth-chromium
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix https://m.gmail.com/ and https://m.googlemail.com/, which don't return a matching CN even with SNI. BUG=80642 TEST=TransportSecurityStateTest.Preloaded Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83199

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M net/base/transport_security_state.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/transport_security_state_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Chris Evans
(Whoever sees it first) Annoying. I'll file a server-side bug but for now it needs ...
9 years, 8 months ago (2011-04-27 04:15:55 UTC) #1
agl
LGTM
9 years, 8 months ago (2011-04-27 13:58:35 UTC) #2
Chris Evans
On 2011/04/27 13:58:35, agl wrote: > LGTM https://www.gmail.com/ and https://www.googlemail.com/ DO work with SNI (with ...
9 years, 8 months ago (2011-04-27 19:58:44 UTC) #3
agl
On Wed, Apr 27, 2011 at 3:58 PM, <cevans@chromium.org> wrote: > https://www.gmail.com/ and https://www.googlemail.com/ DO ...
9 years, 8 months ago (2011-04-27 20:06:12 UTC) #4
agl
On Wed, Apr 27, 2011 at 4:06 PM, Adam Langley <agl@chromium.org> wrote: > If you ...
9 years, 8 months ago (2011-04-27 20:09:11 UTC) #5
Chris Evans
9 years, 8 months ago (2011-04-27 20:09:37 UTC) #6
On 2011/04/27 20:06:12, agl wrote:
> On Wed, Apr 27, 2011 at 3:58 PM,  <mailto:cevans@chromium.org> wrote:
> > https://www.gmail.com/ and https://www.googlemail.com/ DO work with SNI
> > (with
> > the CN http://www.gmail.com and http://www.googlemail.com respectively,
instead of any
> > kind of
> > wildcard) so I'll include them and land.
> 
> If you haven't bugged secops about this although, let me know.

I haven't yet. Did you want to?

I was hoping that www.gmail.com might return a *.gmail.com CN and have made this
change GFE-mapping-only. But... seems not.


Cheers
Chris

> 
> 
> Cheers
> 
> AGL

Powered by Google App Engine
This is Rietveld 408576698