Issue 6902029: Add prototype transitions cache to Map.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6902029: Add prototype transitions cache to Map. (Closed)

Created:
9 years, 8 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Add prototype transitions cache to Map. Committed: http://code.google.com/p/v8/source/detail?r=7679

Patch Set 1 #

Total comments: 3

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+137 lines, -7 lines)			Patch
M	src/flag-definitions.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/heap.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/mark-compact.cc	View	3 chunks	+42 lines, -1 line	0 comments	Download
M	src/objects.h	View	4 chunks	+24 lines, -2 lines	2 comments	Download
M	src/objects.cc	View	2 chunks	+58 lines, -4 lines	1 comment	Download
M	src/objects-inl.h	View	2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 8 months ago (2011-04-26 09:14:23 UTC) #2

LGTM

http://codereview.chromium.org/6902029/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/6902029/diff/1/src/objects.cc#newcode6907
src/objects.cc:6907: if (finger >= capacity) {
I think we want to put a limit on the number of prototype transitions that we
want to cache. In particular since we are doing linear search.

http://codereview.chromium.org/6902029/diff/1/src/objects.h
File src/objects.h (right):

http://codereview.chromium.org/6902029/diff/1/src/objects.h#newcode3755
src/objects.h:3755: // Prototypre transition is a transition that happens
Prototypre -> Prototype

http://codereview.chromium.org/6902029/diff/1/src/objects.h#newcode3877
src/objects.h:3877: static const int kPrototypeTransitionsOffset =
kCodeCacheOffset + kPointerSize;
Line length.

Expand Messages | Collapse Messages