Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 6902011: Cope gracefully with scripts querying stats before client has started. (Closed)

Created:
9 years, 8 months ago by Wez
Modified:
9 years, 7 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Cope gracefully with scripts querying stats before client has started. BUG=80185 TEST=Connect sandboxed from ChromeOS, OR add a delay in ConnectSandboxed in a dev build and use it to connect sandboxed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82973

Patch Set 1 #

Total comments: 1

Patch Set 2 : Nit-picked. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M remoting/client/plugin/chromoting_instance.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/client/plugin/chromoting_scriptable_object.cc View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Wez
Quick fix for race-condition between sandboxed connection startup and connection statistics display update, which prevents ...
9 years, 8 months ago (2011-04-25 22:54:25 UTC) #1
Alpha Left Google
LGTM with 1 nit. http://codereview.chromium.org/6902011/diff/1/remoting/client/plugin/chromoting_instance.cc File remoting/client/plugin/chromoting_instance.cc (right): http://codereview.chromium.org/6902011/diff/1/remoting/client/plugin/chromoting_instance.cc#newcode294 remoting/client/plugin/chromoting_instance.cc:294: if (client_.get() == NULL) nit: ...
9 years, 8 months ago (2011-04-25 23:14:24 UTC) #2
commit-bot: I haz the power
9 years, 8 months ago (2011-04-26 01:45:52 UTC) #3
Change committed as 82973

Powered by Google App Engine
This is Rietveld 408576698