Issue 6902011: Cope gracefully with scripts querying stats before client has started.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6902011: Cope gracefully with scripts querying stats before client has started. (Closed)

Created:
9 years, 8 months ago by Wez

Modified:
9 years, 7 months ago

Reviewers:
commit-bot: I haz the power, Alpha Left Google

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Cope gracefully with scripts querying stats before client has started. BUG=80185 TEST=Connect sandboxed from ChromeOS, OR add a delay in ConnectSandboxed in a dev build and use it to connect sandboxed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82973

Patch Set 1 #

Total comments: 1

Patch Set 2 : Nit-picked. #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
M	remoting/client/plugin/chromoting_instance.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	remoting/client/plugin/chromoting_instance.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	remoting/client/plugin/chromoting_scriptable_object.cc	View		1 chunk	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Wez

Quick fix for race-condition between sandboxed connection startup and connection statistics display update, which prevents ...

9 years, 8 months ago (2011-04-25 22:54:25 UTC) #1

Alpha Left Google

LGTM with 1 nit. http://codereview.chromium.org/6902011/diff/1/remoting/client/plugin/chromoting_instance.cc File remoting/client/plugin/chromoting_instance.cc (right): http://codereview.chromium.org/6902011/diff/1/remoting/client/plugin/chromoting_instance.cc#newcode294 remoting/client/plugin/chromoting_instance.cc:294: if (client_.get() == NULL) nit: ...

9 years, 8 months ago (2011-04-25 23:14:24 UTC) #2

Change committed as 82973

Expand Messages | Collapse Messages