Issue 6901150: Fix unary sub IC heap number code on x64: an untagged double was pushed on the stack and GCd.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6901150: Fix unary sub IC heap number code on x64: an untagged double was pushed on the stack and GCd. (Closed)

Created:
9 years, 7 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix unary sub IC heap number code on x64: an untagged double was pushed on the stack and GCd. BUG=http://code.google.com/p/v8/issues/detail?id=1352 TEST=mjsunit/math-abs Committed: http://code.google.com/p/v8/source/detail?r=7742

Patch Set 1 #

Total comments: 1

Patch Set 2 : Refactor if statement. #

Patch Set 3 : Fix typo on ia32. #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -13 lines)			Patch
	M	src/ia32/code-stubs-ia32.cc	View	1 2	1 chunk	+2 lines, -3 lines	0 comments	Download
	M	src/x64/code-stubs-x64.cc	View	1	1 chunk	+14 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/6901150/diff/1/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): http://codereview.chromium.org/6901150/diff/1/src/x64/code-stubs-x64.cc#newcode556 src/x64/code-stubs-x64.cc:556: if (mode_ == UNARY_OVERWRITE) { How about hoisting ...

9 years, 7 months ago (2011-05-02 12:46:25 UTC) #2

LGTM

Expand Messages | Collapse Messages