Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Issue 6901148: Fix bug LAllocator::FindOptimalSplitPos: it was calculating start_block and end_block incorrectly. (Closed)

Created:
9 years, 7 months ago by Vyacheslav Egorov (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Fix two bugs the LAllocator::FindOptimalSplitPos. - It was calculating start_block and end_block incorrectly. - It was not considering the case when end_block is a loop header itself when searching for the header of the outermost loop. These bugs do not affect correctness of the allocation but can severely degrade it's quality (cause spills in loop bodies). Committed: http://code.google.com/p/v8/source/detail?r=7737

Patch Set 1 #

Patch Set 2 : fix bug with outermost loop header search #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M src/lithium-allocator.cc View 1 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
9 years, 7 months ago (2011-05-01 13:42:08 UTC) #1
fschneider
9 years, 7 months ago (2011-05-02 07:38:06 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698