Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: chrome/renderer/devtools_agent_filter.h

Issue 6901146: Switch IPC::ChannelProxy to use MessageLoopProxy instead of MessageLoop. This allows us to remov... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/service/service_process_control.cc ('k') | chrome/service/service_ipc_server.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_DEVTOOLS_AGENT_FILTER_H_ 5 #ifndef CHROME_RENDERER_DEVTOOLS_AGENT_FILTER_H_
6 #define CHROME_RENDERER_DEVTOOLS_AGENT_FILTER_H_ 6 #define CHROME_RENDERER_DEVTOOLS_AGENT_FILTER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
11 #include "ipc/ipc_channel_proxy.h" 11 #include "ipc/ipc_channel_proxy.h"
12 12
13 class MessageLoop;
13 struct DevToolsMessageData; 14 struct DevToolsMessageData;
14 15
15 // DevToolsAgentFilter is registered as an IPC filter in order to be able to 16 // DevToolsAgentFilter is registered as an IPC filter in order to be able to
16 // dispatch messages while on the IO thread. The reason for that is that while 17 // dispatch messages while on the IO thread. The reason for that is that while
17 // debugging, Render thread is being held by the v8 and hence no messages 18 // debugging, Render thread is being held by the v8 and hence no messages
18 // are being dispatched there. While holding the thread in a tight loop, 19 // are being dispatched there. While holding the thread in a tight loop,
19 // v8 provides thread-safe Api for controlling debugger. In our case v8's Api 20 // v8 provides thread-safe Api for controlling debugger. In our case v8's Api
20 // is being used from this communication agent on the IO thread. 21 // is being used from this communication agent on the IO thread.
21 class DevToolsAgentFilter : public IPC::ChannelProxy::MessageFilter { 22 class DevToolsAgentFilter : public IPC::ChannelProxy::MessageFilter {
22 public: 23 public:
(...skipping 21 matching lines...) Expand all
44 45
45 // Made static to allow DevToolsAgent to use it for replying directly 46 // Made static to allow DevToolsAgent to use it for replying directly
46 // from IO thread. 47 // from IO thread.
47 static int current_routing_id_; 48 static int current_routing_id_;
48 static IPC::Channel* channel_; 49 static IPC::Channel* channel_;
49 50
50 DISALLOW_COPY_AND_ASSIGN(DevToolsAgentFilter); 51 DISALLOW_COPY_AND_ASSIGN(DevToolsAgentFilter);
51 }; 52 };
52 53
53 #endif // CHROME_RENDERER_DEVTOOLS_AGENT_FILTER_H_ 54 #endif // CHROME_RENDERER_DEVTOOLS_AGENT_FILTER_H_
OLDNEW
« no previous file with comments | « chrome/browser/service/service_process_control.cc ('k') | chrome/service/service_ipc_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698