Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 6901136: Update and clean up the fontconfig files (Closed)

Created:
9 years, 7 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
bstell1
CC:
chromium-os-reviews_chromium.org, msb+crosoverlay_chromium.org, Daniel Erat, adlr+crosoverlay_chromium.org, anush, kanliu
Visibility:
Public.

Description

Update and clean up the fontconfig files 1. Add Droid Arabic {Kufi,Nashk},Droid {Sans,Serif} Thai, SIL Absinnica fonts to the alias list for serif, sans-serif and monospace in local.conf Change-Id: I08ff46eb5267cc564e01b009d5cc7a3422ec91d2 2. Do not install 60-latin.conf, 65-nonlatin.conf, 65-fonts-persian.conf. They have a long list of fonts that we don't have on CrOS or we already list in local.conf in the order we want them to be in. Add Lohit Oriya and Lohit Malayalam to the list of fonts for serif, sans-serif and monospace in local.conf. Change-Id: If22e61763d9f2f85942b200c4fcfa566a9a42852 3. Add an orthography patch to zh_tw.orth and zh_hk.orth to remove a couple of very rarely used characters. This (along with #2 above) is an effort to block PMingLiU from popping up at the top of the list when a font covering any Chinese character is requested. It should not, but somehow it does. Change-Id: Id69e564ff1890792798b389cf3ac725c5b6970b8 4. Put 'Song ASC' for serif instead of Droid Sans Fallback. 'Song ASC' is a serif font. BUG=1175 TEST=Go to ar.wikipedia.org and make sure that there's no empty box any more. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=5f52014

Patch Set 1 #

Total comments: 3

Patch Set 2 : add 'Song ASC' for serif in place of D.S.F #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -8 lines) Patch
M media-libs/fontconfig/files/fontconfig-2.7.1-conf-d.patch View 7 chunks +134 lines, -8 lines 0 comments Download
A media-libs/fontconfig/files/fontconfig-2.7.1-orth.patch View 1 chunk +20 lines, -0 lines 0 comments Download
M media-libs/fontconfig/files/local.conf View 1 3 chunks +46 lines, -1 line 0 comments Download
A + media-libs/fontconfig/fontconfig-2.7.1-r19.ebuild View 0 chunks +-1 lines, --1 lines 0 comments Download
M media-libs/fontconfig/fontconfig-2.7.1-r2.ebuild View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jungshik at Google
9 years, 7 months ago (2011-04-29 21:36:29 UTC) #1
bstell1
http://codereview.chromium.org/6901136/diff/1/media-libs/fontconfig/files/fontconfig-2.7.1-conf-d.patch File media-libs/fontconfig/files/fontconfig-2.7.1-conf-d.patch (right): http://codereview.chromium.org/6901136/diff/1/media-libs/fontconfig/files/fontconfig-2.7.1-conf-d.patch#newcode69 media-libs/fontconfig/files/fontconfig-2.7.1-conf-d.patch:69: + 10-hinting.conf \ Hints are on without this file ...
9 years, 7 months ago (2011-04-29 22:02:27 UTC) #2
bstell1
LGTM
9 years, 7 months ago (2011-04-29 22:03:21 UTC) #3
jungshik at Google
9 years, 7 months ago (2011-04-29 22:06:21 UTC) #4
On 2011/04/29 22:02:27, bstell1 wrote:
>
http://codereview.chromium.org/6901136/diff/1/media-libs/fontconfig/files/fon...
> File media-libs/fontconfig/files/fontconfig-2.7.1-conf-d.patch (right):
> 
>
http://codereview.chromium.org/6901136/diff/1/media-libs/fontconfig/files/fon...
> media-libs/fontconfig/files/fontconfig-2.7.1-conf-d.patch:69:
+	10-hinting.conf
> \
> Hints are on without this file so this won't do anything. It is okay to have
> this file as this is what the system is (and should be) doing. Let's hope it
> helps people more in the future that is confuses people.
> 
>
http://codereview.chromium.org/6901136/diff/1/media-libs/fontconfig/files/fon...
> File media-libs/fontconfig/files/fontconfig-2.7.1-orth.patch (right):
> 
>
http://codereview.chromium.org/6901136/diff/1/media-libs/fontconfig/files/fon...
> media-libs/fontconfig/files/fontconfig-2.7.1-orth.patch:9: +#20547
> I cannot say I'm fully qualified to review the changes in this file but it
looks
> okay to me.
> 
>
http://codereview.chromium.org/6901136/diff/1/media-libs/fontconfig/files/loc...
> File media-libs/fontconfig/files/local.conf (right):
> 
>
http://codereview.chromium.org/6901136/diff/1/media-libs/fontconfig/files/loc...
> media-libs/fontconfig/files/local.conf:44: <family>NanumGothic</family>
> I'm curious why for sans the Nanum font is after Droid Sans Fallback (as
> compared to serif where the font is before).

Oops. I meant to add a comment on that, but forgot. 

That is because I don't want Chinese characters in NanumGothic to trump Chinese
characters in Droid Sans Fallback. NanumGothic has Chinese characters (~ 4800 of
them) while NanumMyeongJo does not. 

It'd be easier for us if either of this is the case:

1) NanumGothic does not have any Chinese characters
2) Droid Sans Fallback does not have any Korean characters.

Then, regardless of which order I use to put them in, Korean characters will
come from NanumGothic (superior to those in DSF) and Chinese characters will
come from DSF. 

I'm considering removing Korean characters from Droid Sans Fallback on ChromeOS.

Powered by Google App Engine
This is Rietveld 408576698