chrome/test/data/prerender/prerender_xhr_get.html - Issue 6901128: Cancel prerenders that spawn post requests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/prerender/prerender_xhr_get.html

Issue 6901128: Cancel prerenders that spawn post requests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Method name changes and more tests. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/prerender/prerender_manager.cc ('K') | « chrome/test/data/prerender/prerender_xhr_delete.html ('k') | chrome/test/data/prerender/prerender_xhr_head.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script>

	4 var pageWasPrerendered = false;

	5

	6 // Make sure plugin was not loaded while prerendering.

	7 function DidPrerenderPass() {

	8 pageWasPrerendered = true;

	9 return true;

	10 }

	11

	12 // Make sure DidPrerenderPass() was called first. Otherwise, the page was

	13 // most likely reloaded instead of using the prerendered page.

	14 function DidDisplayPass() {

	15 return pageWasPrerendered;

	16 }

	17

	18 function do_xhr() {

	19 var xhr = new XMLHttpRequest();

	20 xhr.onreadystatechange = function() {

	21 if(xhr.readyState == 4) {

	22 if(xhr.status == 200) {

	23 document.getElementById("dynamic").innerHTML =
	cbentzel 2011/05/02 20:27:38 Is it guaranteed that the GET will have been issue Is it guaranteed that the GET will have been issued [and completed] before DidPrerenderPass and DidDisplayPass are called? dominich 2011/05/02 21:04:55 No. I could change the XHRequests to be synchronou Show quoted text On 2011/05/02 20:27:38, cbentzel wrote: > Is it guaranteed that the GET will have been issued [and completed] before > DidPrerenderPass and DidDisplayPass are called? No. I could change the XHRequests to be synchronous instead but we don't need them to be complete. I don't care about the response as the issuing of the request is enough to catch it and kill it. I could remove the onreadystatechange callback altogether, but it's useful for local testing of the html. cbentzel 2011/05/03 14:24:46 OK. Show quoted text On 2011/05/02 21:04:55, dominic wrote: > On 2011/05/02 20:27:38, cbentzel wrote: > > Is it guaranteed that the GET will have been issued [and completed] before > > DidPrerenderPass and DidDisplayPass are called? > > No. I could change the XHRequests to be synchronous instead but we don't need > them to be complete. I don't care about the response as the issuing of the > request is enough to catch it and kill it. > > I could remove the onreadystatechange callback altogether, but it's useful for > local testing of the html. > OK.
	24 "Received:" + xhr.responseText;

	25 } else {

	26 document.getElementById("dynamic").innerHTML =

	27 "Error code: " + xhr.status;

	28 }

	29 }

	30 };

	31

	32 xhr.open("GET", "prerender_xhr_get.html", true);

	33 xhr.send(null);

	34 }

	35

	36 do_xhr();

	37 </script>

	38 </head>

	39 <body>

	40 <div id="dynamic">

	41 Waiting for XHR response.

	42 </div>

	43 </body>

	44 </html>

OLD	NEW