GTK: Query TopSites for the Most Visited pages and populate fill in the global History menu.

chrome/browser/history/top_sites.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/history/top_sites.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/command_line.h"
@@ skipping 352 matching lines @@
   RemovePinnedURL(url);
   Value* dummy = Value::CreateNullValue();
   {
     DictionaryPrefUpdate update(profile_->GetPrefs(),
                                 prefs::kNTPMostVisitedURLsBlacklist);
     DictionaryValue* blacklist = update.Get();
     blacklist->SetWithoutPathExpansion(GetURLHash(url), dummy);
   }
 
   ResetThreadSafeCache();
+  NotifyTopSitesChanged();
 }
 
 void TopSites::RemoveBlacklistedURL(const GURL& url) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   {
     DictionaryPrefUpdate update(profile_->GetPrefs(),
                                 prefs::kNTPMostVisitedURLsBlacklist);
     DictionaryValue* blacklist = update.Get();
     blacklist->RemoveWithoutPathExpansion(GetURLHash(url), NULL);
   }
   ResetThreadSafeCache();
+  NotifyTopSitesChanged();
 }
 
 bool TopSites::IsBlacklisted(const GURL& url) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   return blacklist_->HasKey(GetURLHash(url));
 }
 
 void TopSites::ClearBlacklistedURLs() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   {
     DictionaryPrefUpdate update(profile_->GetPrefs(),
                                 prefs::kNTPMostVisitedURLsBlacklist);
     DictionaryValue* blacklist = update.Get();
     blacklist->Clear();
   }
   ResetThreadSafeCache();
+  NotifyTopSitesChanged();
 }
 
 void TopSites::AddPinnedURL(const GURL& url, size_t pinned_index) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   GURL old;
   if (GetPinnedURLAtIndex(pinned_index, &old))
     RemovePinnedURL(old);
 
   if (IsURLPinned(url))
     RemovePinnedURL(url);
 
   Value* index = Value::CreateIntegerValue(pinned_index);
 
   {
     DictionaryPrefUpdate update(profile_->GetPrefs(),
                                 prefs::kNTPMostVisitedPinnedURLs);
     DictionaryValue* pinned_urls = update.Get();
     pinned_urls->SetWithoutPathExpansion(GetURLString(url), index);
   }
 
   ResetThreadSafeCache();
+  NotifyTopSitesChanged();
 }
 
 bool TopSites::IsURLPinned(const GURL& url) {
   int tmp;
   return pinned_urls_->GetIntegerWithoutPathExpansion(GetURLString(url), &tmp);
 }
 
 void TopSites::RemovePinnedURL(const GURL& url) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   {
     DictionaryPrefUpdate update(profile_->GetPrefs(),
                                 prefs::kNTPMostVisitedPinnedURLs);
     DictionaryValue* pinned_urls = update.Get();
     pinned_urls->RemoveWithoutPathExpansion(GetURLString(url), NULL);
   }
 
   ResetThreadSafeCache();
+  NotifyTopSitesChanged();
 }
 
 bool TopSites::GetPinnedURLAtIndex(size_t index, GURL* url) {
   for (DictionaryValue::key_iterator it = pinned_urls_->begin_keys();
        it != pinned_urls_->end_keys(); ++it) {
     int current_index;
     if (pinned_urls_->GetIntegerWithoutPathExpansion(*it, &current_index)) {
       if (static_cast<size_t>(current_index) == index) {
         *url = GURL(*it);
         return true;
@@ skipping 375 matching lines @@
     }
   }
 }
 
 void TopSites::SetTopSites(const MostVisitedURLList& new_top_sites) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   MostVisitedURLList top_sites(new_top_sites);
   AddPrepopulatedPages(&top_sites);
 
-  bool changed = false;
   TopSitesDelta delta;
   DiffMostVisited(cache_->top_sites(), top_sites, &delta);
   if (!delta.deleted.empty() || !delta.added.empty() || !delta.moved.empty()) {
-    changed = true;
     backend_->UpdateTopSites(delta);
   }
 
   last_num_urls_changed_ = delta.added.size() + delta.moved.size();
 
   // We always do the following steps (setting top sites in cache, and resetting
   // thread safe cache ...) as this method is invoked during startup at which
   // point the caches haven't been updated yet.
   cache_->SetTopSites(top_sites);
 
   // See if we have any tmp thumbnails for the new sites.
   if (!temp_images_.empty()) {
     for (size_t i = 0; i < top_sites.size(); ++i) {
       const MostVisitedURL& mv = top_sites[i];
       GURL canonical_url = cache_->GetCanonicalURL(mv.url);
       // At the time we get the thumbnail redirects aren't known, so we have to
       // iterate through all the images.
       for (TempImages::iterator it = temp_images_.begin();
            it != temp_images_.end(); ++it) {
         if (canonical_url == cache_->GetCanonicalURL(it->first)) {
           SetPageThumbnailEncoded(mv.url,
                                   it->second.thumbnail,
                                   it->second.thumbnail_score);
-          changed = true;
           temp_images_.erase(it);
           break;
         }
       }
     }
   }
 
   if (top_sites.size() >= kTopSitesNumber)
     temp_images_.clear();
 
   ResetThreadSafeCache();
   ResetThreadSafeImageCache();
-
-  if (changed) {
-    NotificationService::current()->Notify(
-        NotificationType::TOP_SITES_CHANGED,
-        Source<TopSites>(this),
-        NotificationService::NoDetails());
-  }
+  NotifyTopSitesChanged();
 
   // Restart the timer that queries history for top sites. This is done to
   // ensure we stay in sync with history.
   RestartQueryForTopSitesTimer(GetUpdateDelay());
 }
 
 int TopSites::num_results_to_request_from_history() const {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   return kTopSitesNumber + blacklist_->size();
@@ skipping 32 matching lines @@
   ApplyBlacklistAndPinnedURLs(cache_->top_sites(), &cached);
   thread_safe_cache_->SetTopSites(cached);
 }
 
 void TopSites::ResetThreadSafeImageCache() {
   base::AutoLock lock(lock_);
   thread_safe_cache_->SetThumbnails(cache_->images());
   thread_safe_cache_->RemoveUnreferencedThumbnails();
 }
 
+void TopSites::NotifyTopSitesChanged() {
+  NotificationService::current()->Notify(
+      NotificationType::TOP_SITES_CHANGED,
+      Source<TopSites>(this),
+      NotificationService::NoDetails());
+}
+
 void TopSites::RestartQueryForTopSitesTimer(base::TimeDelta delta) {
   if (timer_.IsRunning() && ((timer_start_time_ + timer_.GetCurrentDelay()) <
                              (base::TimeTicks::Now() + delta))) {
     return;
   }
 
   timer_start_time_ = base::TimeTicks::Now();
   timer_.Stop();
   timer_.Start(delta, this, &TopSites::TimerFired);
 }
@@ skipping 55 matching lines @@
   SetTopSites(pages);
 
   // Used only in testing.
   NotificationService::current()->Notify(
       NotificationType::TOP_SITES_UPDATED,
       Source<TopSites>(this),
       Details<CancelableRequestProvider::Handle>(&handle));
 }
 
 }  // namespace history