Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 6901073: dbus-c++: Revert "dbus-c++: Allow deferred object registration." (Closed)

Created:
9 years, 8 months ago by Daniel Erat
Modified:
9 years, 7 months ago
Reviewers:
DaveMoore
CC:
chromium-os-reviews_chromium.org, Elly Fong-Jones, Jason Glasgow, rochberg
Visibility:
Public.

Description

dbus-c++: Revert "dbus-c++: Allow deferred object registration." This reverts commit 5622677bb149fee3fa8c407a09a478bfe694fba9. It breaks the synaptics driver. BUG=chromium-os:11752, chrome-os-partner:3519 TEST=manual: touchpad doesn't work in internal build without this revert, but starts working after the revert Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a40d859

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M include/dbus-c++/object.h View 1 chunk +1 line, -7 lines 0 comments Download
M src/object.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Daniel Erat
Changing third-party APIs like this is dangerous. Has any attempt been made to upstream the ...
9 years, 8 months ago (2011-04-28 00:08:54 UTC) #1
DaveMoore
9 years, 8 months ago (2011-04-28 00:11:26 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698