Issue 6901037: Add "-Wa,-mimplicit-it=always" option to breakpad.gyp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6901037: Add "-Wa,-mimplicit-it=always" option to breakpad.gyp (Closed)

Created:
9 years, 8 months ago by raymes

Modified:
9 years, 7 months ago

Reviewers:
piman

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/branches/742/src/

Visibility:
Public.

Description

Add "-Wa,-mimplicit-it=always" option to breakpad.gyp Add "-Wa,-mimplicit-it=always" option to breakpad.gyp which allows it to be compiled in thumb2 mode. This is not ideal (we should fix the assembly instead). Refer to the bug attached. Following this CL, I will try to remove the -Wa,-mimplicit-it option from the high level build file. TEST=Built chromium on chromiumos on seaboard. Checked that the option was being passed when compiling breakpad only. BUG=80598

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	breakpad/breakpad.gyp	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

raymes

This is the only other place that this option is needed (that I can find).

9 years, 8 months ago (2011-04-26 21:13:27 UTC) #1

LGTM

Expand Messages | Collapse Messages