ppapi/tests/arch_dependent_sizes_64.h - Issue 6901036: Update VideoDecode PPAPI structs to be consistent with media structures, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/tests/arch_dependent_sizes_64.h

Issue 6901036: Update VideoDecode PPAPI structs to be consistent with media structures, part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ppapi/c/dev/ppp_video_decoder_dev.h ('K') | « ppapi/c/dev/ppp_video_decoder_dev.h ('k') | webkit/plugins/ppapi/plugin_delegate.h » ('j') | webkit/plugins/ppapi/ppb_video_decoder_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/tests/arch_dependent_sizes_64.h

diff --git a/ppapi/tests/arch_dependent_sizes_64.h b/ppapi/tests/arch_dependent_sizes_64.h

index 79f87618ed73ea4a17c792755944059231f4d434..3a761f6d78b9e8cb00d0c89dbf9914b1e70db21a 100644

--- a/ppapi/tests/arch_dependent_sizes_64.h

+++ b/ppapi/tests/arch_dependent_sizes_64.h

@@ -17,9 +17,9 @@ PP_COMPILE_ASSERT_SIZE_IN_BYTES(PP_CompletionCallback_Func, 8);

PP_COMPILE_ASSERT_SIZE_IN_BYTES(PP_URLLoaderTrusted_StatusCallback, 8);

PP_COMPILE_ASSERT_STRUCT_SIZE_IN_BYTES(PP_CompletionCallback, 16);

PP_COMPILE_ASSERT_STRUCT_SIZE_IN_BYTES(PP_FileChooserOptions_Dev, 16);

-PP_COMPILE_ASSERT_STRUCT_SIZE_IN_BYTES(PP_Picture_Dev, 16);

+PP_COMPILE_ASSERT_STRUCT_SIZE_IN_BYTES(PP_Picture_Dev, 20);

Ami GONE FROM CHROMIUM 2011/04/26 23:01:57 I wonder what the value of these assertions is.

Ami GONE FROM CHROMIUM 2011/04/29 18:40:34 I still wonder :)

piman 2011/04/29 18:56:17 To protect against regressions, and for NaCl which

PP_COMPILE_ASSERT_STRUCT_SIZE_IN_BYTES(PP_PictureBufferProperties_Dev, 24);

-PP_COMPILE_ASSERT_STRUCT_SIZE_IN_BYTES(PP_VideoBitstreamBuffer_Dev, 16);

+PP_COMPILE_ASSERT_STRUCT_SIZE_IN_BYTES(PP_VideoBitstreamBuffer_Dev, 12);

PP_COMPILE_ASSERT_STRUCT_SIZE_IN_BYTES(PP_VideoDecoderConfig_Dev, 32);

PP_COMPILE_ASSERT_STRUCT_SIZE_IN_BYTES(PPB_VideoDecoder_Dev, 64);

PP_COMPILE_ASSERT_STRUCT_SIZE_IN_BYTES(PPP_VideoDecoder_Dev, 40);

« ppapi/c/dev/ppp_video_decoder_dev.h ('K') | « ppapi/c/dev/ppp_video_decoder_dev.h ('k') | webkit/plugins/ppapi/plugin_delegate.h » ('j') | webkit/plugins/ppapi/ppb_video_decoder_impl.h » ('J')