Update VideoDecode PPAPI structs to be consistent with media structures, part 1

webkit/plugins/ppapi/ppb_video_decoder_impl.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_PLUGINS_PPAPI_PPB_VIDEO_DECODER_IMPL_H_
 #define WEBKIT_PLUGINS_PPAPI_PPB_VIDEO_DECODER_IMPL_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_callback_factory.h"
 #include "base/memory/scoped_ptr.h"
 #include "ppapi/c/pp_var.h"
 #include "webkit/plugins/ppapi/plugin_delegate.h"
 #include "webkit/plugins/ppapi/resource.h"
 
-union PP_PictureData_Dev;
+struct PP_Picture_Dev;
+struct PP_PictureBuffer_Dev;
 struct PP_VideoDecoderConfig_Dev;
 struct PP_VideoBitstreamBuffer_Dev;
 struct PPB_VideoDecoder_Dev;
 
 namespace webkit {
 namespace ppapi {
 
 class PluginInstance;
 
 class PPB_VideoDecoder_Impl : public Resource,
@@ skipping 11 matching lines @@
 
   // PPB_VideoDecoder implementation.
   bool GetConfigs(PP_VideoDecoderConfig_Dev* proto_config,
                   PP_VideoDecoderConfig_Dev* matching_configs,
                   int32_t matching_configs_size,
                   int32_t* num_of_matching_configs);
   bool Init(PP_VideoDecoderConfig_Dev* dec_config);
   bool Decode(PP_VideoBitstreamBuffer_Dev* bitstream_buffer,
               PP_CompletionCallback callback);
   void AssignPictureBuffer(uint32_t no_of_picture_buffers,
-                           PP_PictureData_Dev* picture_buffers);
-  void ReusePictureBuffer(PP_PictureData_Dev* picture_buffer);
+                           PP_PictureBuffer_Dev* picture_buffers);
+  void ReusePictureBuffer(int32_t picture_buffer_id);
   bool Flush(PP_CompletionCallback callback);
   bool Abort(PP_CompletionCallback callback);
 
   // media::VideoDecodeAccelerator::Client implementation.
   virtual void ProvidePictureBuffers(
       uint32_t requested_num_of_buffers,
       const std::vector<uint32_t>& buffer_properties) OVERRIDE;
-  virtual void DismissPictureBuffer(
-      media::VideoDecodeAccelerator::PictureBuffer* picture_buffer) OVERRIDE;
+  virtual void DismissPictureBuffer(int32 picture_buffer_id) OVERRIDE;
   virtual void PictureReady(
-      media::VideoDecodeAccelerator::Picture* picture) OVERRIDE;
+      media::VideoDecodeAccelerator::Picture& picture) OVERRIDE;

[scherkus (not reviewing), 2011/04/26 22:36:34]

why ref versus pointer?

if ref we usually go with a const-ref if possible

[vrk (LEFT CHROMIUM), 2011/04/27 00:40:33]

Const-ref'ed!

   virtual void NotifyEndOfStream() OVERRIDE;
   virtual void NotifyError(
       media::VideoDecodeAccelerator::Error error) OVERRIDE;
 
  private:
+  static media::VideoDecodeAccelerator::PictureBuffer*
+  CreateMediaPictureBuffer(struct PP_PictureBuffer_Dev& input);

[scherkus (not reviewing), 2011/04/26 22:36:34]

nit: c++ doesn't need struct

also ref vs pointer vs const-ref

[vrk (LEFT CHROMIUM), 2011/04/27 00:40:33]

Done.

+
+  static media::VideoDecodeAccelerator::Picture*
+  CreateMediaPicture(struct PP_Picture_Dev& input);

[scherkus (not reviewing), 2011/04/26 22:36:34]

nit: c++ doesn't need struct

also ref vs pointer vs const-ref

[vrk (LEFT CHROMIUM), 2011/04/27 00:40:33]

Done.

+
+  static struct PP_Picture_Dev* CreatePictureDev(

[scherkus (not reviewing), 2011/04/26 22:36:34]

nit: c++ doesn't need struct

also ref vs pointer vs const-ref

[vrk (LEFT CHROMIUM), 2011/04/27 00:40:33]

Done.

+      media::VideoDecodeAccelerator::Picture& input);
+
   void OnAbortComplete();
   void OnBitstreamBufferProcessed();
   void OnFlushComplete();
 
   // This is NULL before initialization, and if this PPB_VideoDecoder_Impl is
   // swapped with another.
   scoped_ptr<PluginDelegate::PlatformVideoDecoder> platform_video_decoder_;
 
   // Factory to produce our callbacks.
   base::ScopedCallbackFactory<PPB_VideoDecoder_Impl> callback_factory_;
 
   PP_CompletionCallback abort_callback_;
   PP_CompletionCallback flush_callback_;
   PP_CompletionCallback bitstream_buffer_callback_;
 
   DISALLOW_COPY_AND_ASSIGN(PPB_VideoDecoder_Impl);
 };
 
 }  // namespace ppapi
 }  // namespace webkit
 
 #endif  // WEBKIT_PLUGINS_PPAPI_PPB_VIDEO_DECODER_IMPL_H_