Update VideoDecode PPAPI structs to be consistent with media structures, part 1

ppapi/c/dev/ppb_video_decoder_dev.h

 /* Copyright (c) 2011 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 #ifndef PPAPI_C_DEV_PPB_VIDEO_DECODER_DEV_H_
 #define PPAPI_C_DEV_PPB_VIDEO_DECODER_DEV_H_
 
 #include "ppapi/c/dev/pp_video_dev.h"
 #include "ppapi/c/pp_completion_callback.h"
 #include "ppapi/c/pp_var.h"
 
 #define PPB_VIDEODECODER_DEV_INTERFACE "PPB_VideoDecoder(Dev);0.5"

[piman, 2011/04/26 20:48:07]

Drive-by: please bump the version if you change the interface.

[Ami GONE FROM CHROMIUM, 2011/04/26 23:01:57]

Is 0.10 greater or smaller than 0.9?  If smaller (as in math) then I propose the
version bump here be 0.500001, since it's feeling like a lot of these interfaces
are going to have a lot more CLs before they're ready for a 1.0 :)

[vrk (LEFT CHROMIUM), 2011/04/27 00:40:33]

Done.

 
 // Video decoder interface.
 //
 // Basic usage:
 //   1. Use GetConfigs() to query potential configurations. Configuration
 //   information includes:
 //     a. Bitstream format.
 //     b. Output picture format.
 //     c. Output picture buffer storage type.
 //   2. Select configuration that suits you and Create() the decoder with the
@@ skipping 113 matching lines @@
   // AssignPictureBuffer should only get called in response to
   // ProvidePictureBuffer?
   //
   // Parameters:
   //   |video_decoder| is the previously created handle to the decoder instance.
   //   |no_of_buffers| how many buffers are behind picture buffer pointer.
   //   |picture_buffer| contains the reference to the picture buffer that was
   //   processed.
   void (*AssignPictureBuffer)(PP_Resource video_decoder,
                               uint32_t no_of_buffers,
-                              union PP_PictureData_Dev* picture_buffer);
+                              struct PP_PictureBuffer_Dev* picture_buffers);
 
   // Tells the decoder to reuse given picture buffer. Typical use of this
   // function is to call from PictureReady callback to recycle picture buffer
   // back to the decoder after blitting the image so that decoder can use the
   // image for output again.
   //
   // The decoder will ignore any picture buffer not previously provided via
   // AssignPictureBuffer.
   //
   // TODO(vmr): figure out how the sync will be handled with command buffer as
   //            there will be possibly lag due to command buffer implementation
   //            to actual GL swap. At that moment decoder may have already taken
   //            the GL textures for writing output again.
   //
   // Parameters:
   //   |video_decoder| is the previously created handle to the decoder instance.
   //   |picture_buffer| contains the reference to the picture buffer that was
   //   processed.
   void (*ReusePictureBuffer)(PP_Resource video_decoder,
-                             union PP_PictureData_Dev* picture_buffer);
+                             int32_t picture_buffer_id);
 
   // Dispatches flushing request to the decoder to flush both input and output
   // buffers. Successful flushing will result in output of the pictures and
   // buffers held inside the decoder and returning of bitstream buffers using
   // the callbacks implemented by the plug-in. Once done with flushing, the
   // decode will call the |callback|.
   //
   // Parameters:
   //   |video_decoder| is the previously created handle to the decoder instance.
   //   |callback| is one-time callback that will be called once the flushing
@@ skipping 15 matching lines @@
   //   |callback| is one-time callback that will be called once the abortion
   //   request has been completed.
   //
   // Returns PP_TRUE on acceptance of abort request and PP_FALSE if request to
   // abort is rejected by the decoder.
   PP_Bool (*Abort)(PP_Resource video_decoder,
                    struct PP_CompletionCallback callback);
 };
 
 #endif  /* PPAPI_C_DEV_PPB_VIDEO_DECODER_DEV_H_ */