Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2299)

Unified Diff: chrome/browser/profiles/profile_impl.h

Issue 6901031: Profile shouldn't own Session/TabRestore services. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix mac build Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_impl.h
diff --git a/chrome/browser/profiles/profile_impl.h b/chrome/browser/profiles/profile_impl.h
index c9a708f45b208191f836c425d0335fd313bf909c..776f662e10e0d41bc50072217752a210755d4f1d 100644
--- a/chrome/browser/profiles/profile_impl.h
+++ b/chrome/browser/profiles/profile_impl.h
@@ -98,17 +98,12 @@ class ProfileImpl : public Profile,
virtual GeolocationPermissionContext* GetGeolocationPermissionContext();
virtual UserStyleSheetWatcher* GetUserStyleSheetWatcher();
virtual FindBarState* GetFindBarState();
- virtual SessionService* GetSessionService();
- virtual void ShutdownSessionService();
- virtual bool HasSessionService() const;
virtual bool HasProfileSyncService() const;
virtual bool DidLastSessionExitCleanly();
virtual BookmarkModel* GetBookmarkModel();
virtual ProtocolHandlerRegistry* GetProtocolHandlerRegistry();
virtual bool IsSameProfile(Profile* profile);
virtual base::Time GetStartTime() const;
- virtual TabRestoreService* GetTabRestoreService();
- virtual void ResetTabRestoreService();
virtual SpellCheckHost* GetSpellCheckHost();
virtual void ReinitializeSpellCheckHost(bool force);
virtual WebKitContext* GetWebKitContext();
@@ -176,9 +171,7 @@ class ProfileImpl : public Profile,
GetRequestContext();
}
- void EnsureSessionServiceCreated() {
- GetSessionService();
- }
+ void EnsureSessionServiceCreated();
void RegisterComponentExtensions();
@@ -246,7 +239,6 @@ class ProfileImpl : public Profile,
scoped_ptr<AutocompleteClassifier> autocomplete_classifier_;
scoped_refptr<WebDataService> web_data_service_;
scoped_refptr<PasswordStore> password_store_;
- scoped_ptr<SessionService> session_service_;
scoped_refptr<WebKitContext> webkit_context_;
scoped_ptr<StatusTray> status_tray_;
scoped_refptr<PersonalDataManager> personal_data_manager_;
@@ -268,8 +260,6 @@ class ProfileImpl : public Profile,
// See GetStartTime for details.
base::Time start_time_;
- scoped_ptr<TabRestoreService> tab_restore_service_;
-
scoped_refptr<SpellCheckHost> spellcheck_host_;
// Indicates whether |spellcheck_host_| has told us initialization is
@@ -281,10 +271,6 @@ class ProfileImpl : public Profile,
scoped_ptr<PromoCounter> instant_promo_counter_;
#endif
- // Set to true when ShutdownSessionService is invoked. If true
- // GetSessionService won't recreate the SessionService.
- bool shutdown_session_service_;
-
// The AppCacheService for this profile, shared by all requests contexts
// associated with this profile. Should only be used on the IO thread.
scoped_refptr<ChromeAppCacheService> appcache_service_;

Powered by Google App Engine
This is Rietveld 408576698