chrome/browser/automation/testing_automation_provider.cc - Issue 6901031: Profile shouldn't own Session/TabRestore services.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/testing_automation_provider.cc

Issue 6901031: Profile shouldn't own Session/TabRestore services. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase again and hope upload works this time Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/automation/testing_automation_provider.cc

diff --git a/chrome/browser/automation/testing_automation_provider.cc b/chrome/browser/automation/testing_automation_provider.cc

index 65eb3a8513bc434c62f64677fb2fb1586a226a18..0b508533f487c3cc9243d8efb251aa09ccf98be2 100644

--- a/chrome/browser/automation/testing_automation_provider.cc

+++ b/chrome/browser/automation/testing_automation_provider.cc

@@ -62,6 +62,7 @@

#include "chrome/browser/profiles/profile_manager.h"

#include "chrome/browser/search_engines/template_url.h"

#include "chrome/browser/search_engines/template_url_model.h"

+#include "chrome/browser/sessions/session_service_factory.h"

#include "chrome/browser/tab_contents/confirm_infobar_delegate.h"

#include "chrome/browser/tab_contents/link_infobar_delegate.h"

#include "chrome/browser/themes/theme_service.h"

@@ -5576,7 +5577,7 @@ void TestingAutomationProvider::ShutdownSessionService(int handle,

bool* result) {

if (browser_tracker_->ContainsHandle(handle)) {

Browser* browser = browser_tracker_->GetResource(handle);

- browser->profile()->ShutdownSessionService();

+ SessionServiceFactory::ShutdownForProfile(browser->profile());

*result = true;

} else {

*result = false;