Issue 6900009: Delay release of object Vars

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6900009: Delay release of object Vars (Closed)

Created:
9 years, 8 months ago by piman

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Delay release of object Vars BUG=chromium-os:14397 TEST=grooveshark Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82667

Patch Set 3 : add comment #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -6 lines)			Patch
	M	ppapi/proxy/ppb_var_deprecated_proxy.h	View	1	3 chunks	+5 lines, -1 line	0 comments	Download
	M	ppapi/proxy/ppb_var_deprecated_proxy.cc	View	1 2	4 chunks	+32 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

http://codereview.chromium.org/6900009/diff/2001/ppapi/proxy/ppb_var_deprecated_proxy.cc File ppapi/proxy/ppb_var_deprecated_proxy.cc (right): http://codereview.chromium.org/6900009/diff/2001/ppapi/proxy/ppb_var_deprecated_proxy.cc#newcode367 ppapi/proxy/ppb_var_deprecated_proxy.cc:367: MessageLoop::current()->PostNonNestableTask(FROM_HERE, Can you add a very long comment here ...

9 years, 8 months ago (2011-04-22 01:05:04 UTC) #2

piman

9 years, 8 months ago (2011-04-22 02:28:11 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 6900009: Delay release of object Vars (Closed)

Description

Patch Set 1 #

Patch Set 2 : fgit try #

Patch Set 3 : add comment #

Messages