Issue 6900001: Re-enable BWSI profile permissions test to coincide with landing of 13173 fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6900001: Re-enable BWSI profile permissions test to coincide with landing of 13173 fix (Closed)

Created:
9 years, 8 months ago by jimhebert

Modified:
9 years, 7 months ago

Reviewers:
Chris Masone

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://gitrw.chromium.org:9222/autotest.git@master

Visibility:
Public.

Description

Re-enable BWSI profile permissions test to coincide with landing of 13173 fix Change-Id: If6270dcd8d2285b946a79d12863812abfd290934 BUG=chromium-os:13173 TEST=run_remote_test ... security_ProfilePermissions will now run 2 iterations, one tagged "BWSI" Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a3a6e01

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	client/site_tests/security_ProfilePermissions/control	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Chris Masone

9 years, 8 months ago (2011-04-21 22:55:25 UTC) #2

LGTM

On Thu, Apr 21, 2011 at 3:25 PM, <jimhebert@chromium.org> wrote:

> Reviewers: Chris Masone,
>
> Description:
> Re-enable BWSI profile permissions test to coincide with landing of 13173
> fix
>
> Change-Id: If6270dcd8d2285b946a79d12863812abfd290934
>
> BUG=chromium-os:13173
> TEST=run_remote_test ... security_ProfilePermissions will now run 2
> iterations,
> one tagged "BWSI"
>
>
> Please review this at http://codereview.chromium.org/6900001/
>
> SVN Base: ssh://gitrw.chromium.org:9222/autotest.git@master
>
> Affected files:
>  M client/site_tests/security_ProfilePermissions/control
>
>
> Index: client/site_tests/security_ProfilePermissions/control
> diff --git a/client/site_tests/security_ProfilePermissions/control
> b/client/site_tests/security_ProfilePermissions/control
> index
>
73c195b6ba86ffdc3cde34e3250c889d2f0f2e77..fa0b70fb8aa4a3709175801b85b2c881ef986540
> 100644
> --- a/client/site_tests/security_ProfilePermissions/control
> +++ b/client/site_tests/security_ProfilePermissions/control
> @@ -17,6 +17,4 @@ TEST_CATEGORY = "Functional"
>  TEST_TYPE = "client"
>
>  job.run_test("security_ProfilePermissions", creds='$default', tag='login')
> -#TODO(jimhebert) Uncomment this after chromium-os:13173 is fixed.
> -#job.run_test("security_ProfilePermissions", creds=None, tag='BWSI')
> -
> +job.run_test("security_ProfilePermissions", creds=None, tag='BWSI')
>
>
>

Expand Messages | Collapse Messages