PPAPI: Force async callback invocation option.

ppapi/tests/test_utils.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/tests/test_utils.h"
 
 #include <stdio.h>
 
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/cpp/module.h"
@@ skipping 11 matching lines @@
   std::string result = method + std::string(" failed with error: ") +
       error_as_string;
   if (error == PP_ERROR_NOSPACE)
     result += ". Did you run the test with --unlimited-quota-for-files?";
   return result;
 }
 
 TestCompletionCallback::TestCompletionCallback(PP_Instance instance)
     : have_result_(false),
       result_(PP_OK_COMPLETIONPENDING),
+      force_async_(false),
+      post_quit_task_(false),
+      run_count_(0),
+      instance_(instance) {
+}
+
+TestCompletionCallback::TestCompletionCallback(PP_Instance instance,
+                                               bool force_async)
+    : result_(PP_OK_COMPLETIONPENDING),

[brettw, 2011/06/27 23:59:03]

You forgot to initialize have_result. This caused a lot of failures for me and I
spent some time tracking it down to this.

[polina, 2011/06/28 00:11:27]

Lost somebody else's new field during a sync. Thanks for catching this!

+      force_async_(force_async),
       post_quit_task_(false),
       run_count_(0),
       instance_(instance) {
 }
 
 int32_t TestCompletionCallback::WaitForResult() {
   if (!have_result_) {
     result_ = PP_OK_COMPLETIONPENDING;  // Reset
     post_quit_task_ = true;
     GetTestingInterface()->RunMessageLoop(instance_);
   }
   have_result_ = false;
   return result_;
 }
 
 TestCompletionCallback::operator pp::CompletionCallback() const {
+  int32_t flags = (force_async_ ? 0 : PP_COMPLETIONCALLBACK_FLAG_OPTIONAL);
   return pp::CompletionCallback(&TestCompletionCallback::Handler,
-                                const_cast<TestCompletionCallback*>(this));
+                                const_cast<TestCompletionCallback*>(this),
+                                flags);
 }
 
 // static
 void TestCompletionCallback::Handler(void* user_data, int32_t result) {
   TestCompletionCallback* callback =
       static_cast<TestCompletionCallback*>(user_data);
   callback->result_ = result;
   callback->have_result_ = true;
   callback->run_count_++;
   if (callback->post_quit_task_) {
     callback->post_quit_task_ = false;
     GetTestingInterface()->QuitMessageLoop(callback->instance_);
   }
 }