PPAPI: Force async callback invocation option.

ppapi/cpp/dev/video_decoder_dev.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/cpp/dev/video_decoder_dev.h"
 
 #include "ppapi/c/dev/ppb_video_decoder_dev.h"
 #include "ppapi/c/dev/ppp_video_decoder_dev.h"
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/cpp/common.h"
 #include "ppapi/cpp/instance.h"
 #include "ppapi/cpp/module.h"
 #include "ppapi/cpp/module_impl.h"
+#include "ppapi/thunk/common.h"
 
 namespace pp {
 
 namespace {
 
 template <> const char* interface_name<PPB_VideoDecoder_Dev>() {
   return PPB_VIDEODECODER_DEV_INTERFACE;
 }
 
 }  // namespace
 
 VideoDecoder::VideoDecoder(const Instance* instance, Client* client)
     : client_(client) {
   if (!has_interface<PPB_VideoDecoder_Dev>())
     return;
   PassRefFromConstructor(get_interface<PPB_VideoDecoder_Dev>()->Create(
       instance->pp_instance()));
 }
 
 VideoDecoder::~VideoDecoder() {}
 
 int32_t VideoDecoder::Initialize(const PP_VideoConfigElement* config,
                                  CompletionCallback callback) {
   if (!has_interface<PPB_VideoDecoder_Dev>())
-    return PP_ERROR_NOINTERFACE;
+    return callback.MayForce(static_cast<int32_t>(PP_ERROR_NOINTERFACE));

[piman, 2011/06/07 17:32:14]

no need for static_cast ? here and below

[polina, 2011/06/09 23:53:51]

Done.

   return get_interface<PPB_VideoDecoder_Dev>()->Initialize(
       pp_resource(), config, callback.pp_completion_callback());
 }
 
 bool VideoDecoder::GetConfigs(Instance* instance,
                               const PP_VideoConfigElement* prototype_config,
                               PP_VideoConfigElement* matching_configs,
                               uint32_t matching_configs_size,
                               uint32_t* num_of_matching_configs) {
   if (!has_interface<PPB_VideoDecoder_Dev>())
@@ skipping 16 matching lines @@
   if (!has_interface<PPB_VideoDecoder_Dev>() || !pp_resource())
     return;
   get_interface<PPB_VideoDecoder_Dev>()->AssignSysmemBuffers(
       pp_resource(), buffers.size(), &buffers[0]);
 }
 
 int32_t VideoDecoder::Decode(
     const PP_VideoBitstreamBuffer_Dev& bitstream_buffer,
     CompletionCallback callback) {
   if (!has_interface<PPB_VideoDecoder_Dev>())
-    return PP_ERROR_NOINTERFACE;
-  if (!pp_resource())

[piman, 2011/06/07 17:32:14]

Why removing the check for pp_resource ?

[polina, 2011/06/09 23:53:51]

This check must be and is performed by the C function (which is why no other C++
wrapper does it).

-    return PP_ERROR_BADRESOURCE;
+    return callback.MayForce(static_cast<int32_t>(PP_ERROR_NOINTERFACE));
   return get_interface<PPB_VideoDecoder_Dev>()->Decode(
       pp_resource(), &bitstream_buffer, callback.pp_completion_callback());
 }
 
 void VideoDecoder::ReusePictureBuffer(int32_t picture_buffer_id) {
   if (!has_interface<PPB_VideoDecoder_Dev>() || !pp_resource())
     return;
   get_interface<PPB_VideoDecoder_Dev>()->ReusePictureBuffer(
       pp_resource(), picture_buffer_id);
 }
 
 int32_t VideoDecoder::Flush(CompletionCallback callback) {
   if (!has_interface<PPB_VideoDecoder_Dev>())
-    return PP_ERROR_NOINTERFACE;
-  if (!pp_resource())
-    return PP_ERROR_BADRESOURCE;
+    return callback.MayForce(static_cast<int32_t>(PP_ERROR_NOINTERFACE));
   return get_interface<PPB_VideoDecoder_Dev>()->Flush(
       pp_resource(), callback.pp_completion_callback());
 }
 
 int32_t VideoDecoder::Abort(CompletionCallback callback) {
   if (!has_interface<PPB_VideoDecoder_Dev>())
-    return PP_ERROR_NOINTERFACE;
-  if (!pp_resource())
-    return PP_ERROR_BADRESOURCE;
+    return callback.MayForce(static_cast<int32_t>(PP_ERROR_NOINTERFACE));
   return get_interface<PPB_VideoDecoder_Dev>()->Abort(
       pp_resource(), callback.pp_completion_callback());
 }
 
 }  // namespace pp