Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 6899051: Print Preview: Get rid of the loading div on failure. (Closed)

Created:
9 years, 8 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
dpapad
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Print Preview: Get rid of the loading div on failure. BUG=none TEST=Remove the PDF plugin and try to print preview. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82776

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/resources/print_preview.js View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
9 years, 8 months ago (2011-04-23 01:24:03 UTC) #1
dpapad
LGTM
9 years, 8 months ago (2011-04-23 01:37:55 UTC) #2
Lei Zhang
9 years, 8 months ago (2011-04-23 01:46:42 UTC) #3
Actually there's already a .hidden class selector, so I just used that in patch
set 2.

Powered by Google App Engine
This is Rietveld 408576698