Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Issue 6899031: Remove the obsolete prebuilt infrastructure files and disable multiarch. (Closed)

Created:
9 years, 8 months ago by sehr (please use chromium)
Modified:
9 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Remove the obsolete prebuilt infrastructure files and disable multiarch. The prebuilt infrastructure, when it is ready, should use PPAPI nexes depending on IRT. BUG=none TEST=all - multiarch Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=5002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6530 lines) Patch
M SConstruct View 1 chunk +5 lines, -1 line 0 comments Download
D tests/prebuilt/arm/gold-barebones_hello_world.nexe View Binary file 0 comments Download
D tests/prebuilt/arm/srpc_hw.nexe View Binary file 0 comments Download
D tests/prebuilt/nacl_js_lib.js View 1 chunk +0 lines, -149 lines 0 comments Download
D tests/prebuilt/srpc_hw.html View 1 chunk +0 lines, -78 lines 0 comments Download
D tests/prebuilt/srpc_hw.nmf View 1 chunk +0 lines, -7 lines 0 comments Download
D tests/prebuilt/x64/index.html View 1 chunk +0 lines, -76 lines 0 comments Download
D tests/prebuilt/x64/nacl.png View Binary file 0 comments Download
D tests/prebuilt/x64/nacl_js_lib.js View 1 chunk +0 lines, -149 lines 0 comments Download
D tests/prebuilt/x64/npapi_hw.html View 1 chunk +0 lines, -95 lines 0 comments Download
D tests/prebuilt/x64/npapi_hw.nexe View Binary file 0 comments Download
D tests/prebuilt/x64/pepper_plugin.html View 1 chunk +0 lines, -118 lines 0 comments Download
D tests/prebuilt/x64/pepper_plugin.nexe View Binary file 0 comments Download
D tests/prebuilt/x64/server_test.html View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/prebuilt/x64/srpc_basic.html View 1 chunk +0 lines, -701 lines 0 comments Download
D tests/prebuilt/x64/srpc_hw.html View 1 chunk +0 lines, -78 lines 0 comments Download
D tests/prebuilt/x64/srpc_hw.nexe View Binary file 0 comments Download
D tests/prebuilt/x64/srpc_hw_ppapi.html View 1 chunk +0 lines, -87 lines 0 comments Download
D tests/prebuilt/x64/srpc_hw_v2.nexe View Binary file 0 comments Download
D tests/prebuilt/x64/srpc_nrd_client.nexe View Binary file 0 comments Download
D tests/prebuilt/x64/srpc_nrd_server.nexe View Binary file 0 comments Download
D tests/prebuilt/x64/srpc_nrd_xfer.html View 1 chunk +0 lines, -304 lines 0 comments Download
D tests/prebuilt/x64/srpc_plugin.html View 1 chunk +0 lines, -373 lines 0 comments Download
D tests/prebuilt/x64/srpc_shm.html View 1 chunk +0 lines, -765 lines 0 comments Download
D tests/prebuilt/x64/srpc_shm.nexe View Binary file 0 comments Download
D tests/prebuilt/x64/srpc_sockaddr.html View 1 chunk +0 lines, -256 lines 0 comments Download
D tests/prebuilt/x64/srpc_test.nexe View Binary file 0 comments Download
D tests/prebuilt/x86/OldAbiVersion/nacl_js_lib.js View 1 chunk +0 lines, -149 lines 0 comments Download
D tests/prebuilt/x86/OldAbiVersion/srpc_hw.html View 1 chunk +0 lines, -78 lines 0 comments Download
D tests/prebuilt/x86/OldAbiVersion/srpc_hw.nexe View Binary file 0 comments Download
D tests/prebuilt/x86/index.html View 1 chunk +0 lines, -76 lines 0 comments Download
D tests/prebuilt/x86/nacl.png View Binary file 0 comments Download
D tests/prebuilt/x86/nacl_js_lib.js View 1 chunk +0 lines, -149 lines 0 comments Download
D tests/prebuilt/x86/npapi_hw.html View 1 chunk +0 lines, -95 lines 0 comments Download
D tests/prebuilt/x86/npapi_hw.nexe View Binary file 0 comments Download
D tests/prebuilt/x86/pepper_plugin.html View 1 chunk +0 lines, -118 lines 0 comments Download
D tests/prebuilt/x86/pepper_plugin.nexe View Binary file 0 comments Download
D tests/prebuilt/x86/server_test.html View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/prebuilt/x86/srpc_basic.html View 1 chunk +0 lines, -701 lines 0 comments Download
D tests/prebuilt/x86/srpc_hw.html View 1 chunk +0 lines, -78 lines 0 comments Download
D tests/prebuilt/x86/srpc_hw.nexe View Binary file 0 comments Download
D tests/prebuilt/x86/srpc_hw_ppapi.html View 1 chunk +0 lines, -87 lines 0 comments Download
D tests/prebuilt/x86/srpc_hw_v2.nexe View Binary file 0 comments Download
D tests/prebuilt/x86/srpc_nrd_client.nexe View Binary file 0 comments Download
D tests/prebuilt/x86/srpc_nrd_server.nexe View Binary file 0 comments Download
D tests/prebuilt/x86/srpc_nrd_xfer.html View 1 chunk +0 lines, -304 lines 0 comments Download
D tests/prebuilt/x86/srpc_plugin.html View 1 chunk +0 lines, -373 lines 0 comments Download
D tests/prebuilt/x86/srpc_shm.html View 1 chunk +0 lines, -765 lines 0 comments Download
D tests/prebuilt/x86/srpc_shm.nexe View Binary file 0 comments Download
D tests/prebuilt/x86/srpc_sockaddr.html View 1 chunk +0 lines, -256 lines 0 comments Download
D tests/prebuilt/x86/srpc_test.nexe View Binary file 0 comments Download

Messages

Total messages: 6 (0 generated)
sehr (please use chromium)
Thanks in advance for reviewing this.
9 years, 8 months ago (2011-04-22 17:24:10 UTC) #1
David Springer
LGTM
9 years, 8 months ago (2011-04-22 17:24:49 UTC) #2
sehr (please use chromium)
On 2011/04/22 17:24:49, David Springer wrote: > LGTM Committed as r5002.
9 years, 8 months ago (2011-04-23 03:27:40 UTC) #3
Mark Seaborn
This change breaks the NaCl/Chrome integration bot, which now fails with: [ RUN ] NaClUITest.ServerTest ...
9 years, 8 months ago (2011-04-25 15:05:20 UTC) #4
sehr (please use chromium)
http://codereview.chromium.org/6896051 is in your inbox. On Mon, Apr 25, 2011 at 8:05 AM, <mseaborn@chromium.org> wrote: ...
9 years, 8 months ago (2011-04-25 15:52:57 UTC) #5
sehr (please use chromium)
9 years, 8 months ago (2011-04-25 16:17:39 UTC) #6
And of course, that isn't enough.  Still working on a CL.

On Mon, Apr 25, 2011 at 8:52 AM, David Sehr <sehr@google.com> wrote:

>  http://codereview.chromium.org/6896051 is in your inbox.
>
>
> On Mon, Apr 25, 2011 at 8:05 AM, <mseaborn@chromium.org> wrote:
>
>> This change breaks the NaCl/Chrome integration bot, which now fails with:
>>
>> [ RUN      ] NaClUITest.ServerTest
>> /b/build/slave/mac-nacl-chrome/build/src/chrome/test/ui/ui_test.cc:753:
>> Failure
>> Failed
>> Timeout reached in WaitUntilCookieValue
>> /b/build/slave/mac-nacl-chrome/build/src/chrome/test/nacl/nacl_test.cc:70:
>> Failure
>> Value of: test_result
>>  Actual: false
>> Expected: true
>> [  FAILED  ] NaClUITest.ServerTest (33216 ms)
>>
>> This will prevent us from updating Chrome's DEPS.  Do you have a change
>> ready to
>> disable this test on the Chrome side?
>>
>> Mark
>>
>>
>>
>> http://codereview.chromium.org/6899031/
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

Powered by Google App Engine
This is Rietveld 408576698