Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: chrome/browser/chromeos/name_value_pairs_parser_unittest.cc

Issue 6899021: HWID and VPD values should be accessible via SystemAccess::GetMachineStatistic (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: move ChromeosInfo to UI thread only Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/name_value_pairs_parser_unittest.cc
diff --git a/chrome/browser/chromeos/system_access_unittest.cc b/chrome/browser/chromeos/name_value_pairs_parser_unittest.cc
similarity index 71%
rename from chrome/browser/chromeos/system_access_unittest.cc
rename to chrome/browser/chromeos/name_value_pairs_parser_unittest.cc
index 5da8193e2d69484accd79a0ae21188bee8bc07d1..0f5e35065b73abfe5bed91ccb6748884d503abed 100644
--- a/chrome/browser/chromeos/system_access_unittest.cc
+++ b/chrome/browser/chromeos/name_value_pairs_parser_unittest.cc
@@ -2,15 +2,14 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/chromeos/system_access.h"
+#include "chrome/browser/chromeos/name_value_pairs_parser.h"
#include "base/basictypes.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace chromeos {
-namespace system_access {
-TEST(SystemAccessTest, TestGetSingleValueFromTool) {
+TEST(NameValuePairsParser, TestGetSingleValueFromTool) {
MachineInfo machine_info;
NameValuePairsParser parser(&machine_info);
const char* command[] = { "echo", "Foo" };
@@ -20,7 +19,7 @@ TEST(SystemAccessTest, TestGetSingleValueFromTool) {
EXPECT_EQ("Foo", machine_info["foo"]);
}
-TEST(SystemAccessTest, TestParseNameValuePairsFromTool) {
+TEST(NameValuePairsParser, TestParseNameValuePairsFromTool) {
MachineInfo machine_info;
NameValuePairsParser parser(&machine_info);
const char* command1[] = { "echo", "foo=Foo bar=Bar\nfoobar=FooBar\n" };
@@ -48,7 +47,18 @@ TEST(SystemAccessTest, TestParseNameValuePairsFromTool) {
const char* command4[] = { "echo", "foo=Foo,=Bar" };
EXPECT_FALSE(parser.ParseNameValuePairsFromTool(
arraysize(command4), command4, "=", ",\n"));
+
+ machine_info.clear();
+ const char* command5[] = { "echo",
+ "\"initial_locale\"=\"ja\"\n"
+ "\"initial_timezone\"=\"Asia/Tokyo\"\n"
+ "\"keyboard_layout\"=\"mozc-jp\"\n" };
+ EXPECT_TRUE(parser.ParseNameValuePairsFromTool(
+ arraysize(command5), command5, "=", "\n"));
+ ASSERT_EQ(3U, machine_info.size());
+ EXPECT_EQ("ja", machine_info["initial_locale"]);
+ EXPECT_EQ("Asia/Tokyo", machine_info["initial_timezone"]);
+ EXPECT_EQ("mozc-jp", machine_info["keyboard_layout"]);
}
-} // namespace system_access
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698