Issue 6899011: LiveEdit: optimize substring comparison

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6899011: LiveEdit: optimize substring comparison (Closed)

Created:
9 years, 8 months ago by Peter Rybin

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, sgjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

LiveEdit: optimize substring comparison Committed: http://code.google.com/p/v8/source/detail?r=7710

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -25 lines)			Patch
	M	src/isolate.h	View		2 chunks	+0 lines, -10 lines	0 comments	Download
	M	src/liveedit.cc	View		4 chunks	+9 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM Sorry for the long response-time (I did not check my gmail.com account for some ...

9 years, 7 months ago (2011-04-28 15:01:26 UTC) #2

Peter Rybin

9 years, 7 months ago (2011-04-28 20:23:31 UTC) #3

On 2011/04/28 15:01:26, Søren Gjesse wrote:
> LGTM
> 
> Sorry for the long response-time (I did not check my http://gmail.com account
for some
> time).

Thanks for review.
My fault with email -- I did last change too long ago and lost accuracy.

Expand Messages | Collapse Messages