Issue 6899003: FileManager: assorted fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6899003: FileManager: assorted fixes (Closed)

Created:
9 years, 8 months ago by rginda

Modified:
9 years, 7 months ago

Reviewers:
zel

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

FileManager: assorted fixes * Switch webkitRequestFileSystem/webkitResolveLocalFileSystemURL. * Stop sharing selection models between grid/table, it doesn't work. * Remove readAsDataURL in favor of toURL * Fix case where chrome sets defaultPath to the downloads folder. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82577

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -28 lines)			Patch
M	chrome/browser/resources/file_manager/js/exif_reader.js	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View	5 chunks	+8 lines, -19 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/harness.js	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/mock_chrome.js	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages