Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 6898026: Eliminate wstring from base/utf_offset_string_conversions.h, net/base/escape.h, and net/base/net_... (Closed)

Created:
9 years, 8 months ago by Peter Kasting
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Erik does not do reviews, brettw-cc_chromium.org, jam, cbentzel+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org
Visibility:
Public.

Description

Eliminate wstring from base/utf_offset_string_conversions.h, net/base/escape.h, and net/base/net_util.h, and reduce the API surfaces in various places slightly where possible. BUG=23581 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83948

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 5

Patch Set 3 : '' #

Total comments: 5

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+966 lines, -1437 lines) Patch
M base/utf_offset_string_conversions.h View 1 2 3 4 5 6 2 chunks +32 lines, -44 lines 0 comments Download
M base/utf_offset_string_conversions.cc View 1 2 3 4 5 2 chunks +50 lines, -150 lines 0 comments Download
M base/utf_offset_string_conversions_unittest.cc View 1 2 3 4 5 4 chunks +57 lines, -91 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_settings_state.cc View 1 2 3 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm View 1 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/common/extensions/extension.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M net/base/escape.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M net/base/escape.cc View 1 7 chunks +16 lines, -34 lines 0 comments Download
M net/base/escape_unittest.cc View 1 5 chunks +27 lines, -24 lines 0 comments Download
M net/base/net_util.h View 1 2 5 chunks +8 lines, -57 lines 0 comments Download
M net/base/net_util.cc View 1 2 3 4 5 15 chunks +439 lines, -554 lines 1 comment Download
M net/base/net_util_unittest.cc View 1 2 12 chunks +238 lines, -336 lines 1 comment Download
M net/base/registry_controlled_domain.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M net/base/registry_controlled_domain.cc View 1 3 chunks +1 line, -24 lines 0 comments Download
M net/base/registry_controlled_domain_unittest.cc View 1 2 3 6 chunks +79 lines, -80 lines 0 comments Download
M net/base/sdch_manager.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M ui/base/text/text_elider.cc View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Peter Kasting
9 years, 8 months ago (2011-04-22 22:38:17 UTC) #1
brettw
LGTM http://codereview.chromium.org/6898026/diff/28/net/base/net_util.cc File net/base/net_util.cc (right): http://codereview.chromium.org/6898026/diff/28/net/base/net_util.cc#newcode1566 net/base/net_util.cc:1566: url_parse::Parsed parsed_temp; I'm assuming you just moved this ...
9 years, 8 months ago (2011-04-25 16:19:43 UTC) #2
Peter Kasting
I'll commit this once I figure out the test failures. http://codereview.chromium.org/6898026/diff/28/net/base/net_util.cc File net/base/net_util.cc (right): http://codereview.chromium.org/6898026/diff/28/net/base/net_util.cc#newcode1566 ...
9 years, 8 months ago (2011-04-25 17:44:52 UTC) #3
Avi (use Gerrit)
http://codereview.chromium.org/6898026/diff/28/net/base/net_util.cc File net/base/net_util.cc (right): http://codereview.chromium.org/6898026/diff/28/net/base/net_util.cc#newcode1614 net/base/net_util.cc:1614: string16 kHTTP = ASCIIToUTF16("http://"); eww. const char like kFTP ...
9 years, 8 months ago (2011-04-25 17:52:06 UTC) #4
brettw
http://codereview.chromium.org/6898026/diff/28/net/base/net_util.cc File net/base/net_util.cc (right): http://codereview.chromium.org/6898026/diff/28/net/base/net_util.cc#newcode1624 net/base/net_util.cc:1624: (url.host().compare(0, arraysize(kFTP) - 1, kFTP) != 0); The host ...
9 years, 8 months ago (2011-04-25 17:56:28 UTC) #5
Peter Kasting
Fixing the test failures exposed a number of problems. This version of the patch does ...
9 years, 8 months ago (2011-04-26 18:41:55 UTC) #6
Peter Kasting
On 2011/04/26 18:41:55, Peter Kasting wrote: > I'd like you and Brett to both take ...
9 years, 8 months ago (2011-04-26 18:42:49 UTC) #7
mrossetti
LGTM Stylistics comments only. I only reviewed utf_offset_string_conversions*.* and net_util*.*. http://codereview.chromium.org/6898026/diff/10001/net/base/net_util.cc File net/base/net_util.cc (right): http://codereview.chromium.org/6898026/diff/10001/net/base/net_util.cc#newcode661 ...
9 years, 8 months ago (2011-04-26 22:13:33 UTC) #8
Peter Kasting
New snap up. http://codereview.chromium.org/6898026/diff/10001/net/base/net_util.cc File net/base/net_util.cc (right): http://codereview.chromium.org/6898026/diff/10001/net/base/net_util.cc#newcode661 net/base/net_util.cc:661: // Functions may stack-allocate one of ...
9 years, 8 months ago (2011-04-27 02:07:19 UTC) #9
mrossetti
LGTM Sweet!
9 years, 8 months ago (2011-04-27 02:15:01 UTC) #10
Peter Kasting
Brett, are you OK with the changes since patch set 2?
9 years, 8 months ago (2011-04-27 15:16:51 UTC) #11
brettw
LGTM, sorry, I didn't realize you needed another pass. http://codereview.chromium.org/6898026/diff/11033/net/base/net_util.cc File net/base/net_util.cc (right): http://codereview.chromium.org/6898026/diff/11033/net/base/net_util.cc#newcode724 net/base/net_util.cc:724: ...
9 years, 8 months ago (2011-04-27 17:47:51 UTC) #12
willchan no longer on Chromium
9 years, 7 months ago (2011-05-03 20:02:17 UTC) #13
LGTM for net/

Powered by Google App Engine
This is Rietveld 408576698