Issue 6898001: WebUI Prefs: Resize autocomplete list on window resize

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6898001: WebUI Prefs: Resize autocomplete list on window resize (Closed)

Created:
9 years, 8 months ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
csilv

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

WebUI Prefs: Resize autocomplete list on window resize This isn't perfect, since there is a bit of lag, but putting the list in the field's parent element has visibility and layering problems (that was the original approach used by the autocomplete list when it landed). BUG=80029 TEST=Resize window while the autocomplete window is showing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82716

Patch Set 1 #

Total comments: 1

Patch Set 2 : Condense syncWidthToInput #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	chrome/browser/resources/options/autocomplete_list.js	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
	M	chrome/browser/resources/options/browser_options.js	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

csilv

9 years, 8 months ago (2011-04-22 00:10:55 UTC) #2

LGTM

http://codereview.chromium.org/6898001/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/autocomplete_list.js (right):

http://codereview.chromium.org/6898001/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/autocomplete_list.js:177: if (!input)
I'd prefer to make this more concise by saying:

if (input)
  this.style.width = input.getBoundingClientRect().width + 'px';

It's up to you.

Expand Messages | Collapse Messages