Base: Fix FileVersionInfo::CreateFileVersionInfoForCurrentModule so that

base/file_version_info_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_version_info_win.h"
 
 #include <windows.h>
 
 #include "base/file_path.h"
 #include "base/file_version_info.h"
@@ skipping 13 matching lines @@
 FileVersionInfoWin::~FileVersionInfoWin() {
   DCHECK(data_.get());
 }
 
 typedef struct {
   WORD language;
   WORD code_page;
 } LanguageAndCodePage;
 
 // static
-FileVersionInfo* FileVersionInfo::CreateFileVersionInfoForCurrentModule() {
-  FilePath app_path;
-  if (!PathService::Get(base::FILE_MODULE, &app_path))
-    return NULL;
+FileVersionInfo* FileVersionInfo::CreateFileVersionInfoForModule(
+    HMODULE module) {
+  // Note that the use of MAX_PATH is basically in line with what we do for
+  // all registered paths (PathProviderWin).
+  wchar_t system_buffer[MAX_PATH];
+  system_buffer[0] = 0;
+  GetModuleFileName(module, system_buffer, MAX_PATH);

[wtc, 2011/04/22 20:00:09]

Should we check if GetModuleFileName fails (returns 0)?

[rvargas (doing something else), 2011/04/22 21:40:05]

Done.

+  FilePath app_path(system_buffer);
 
   return CreateFileVersionInfo(app_path);
 }
 
 // static
 FileVersionInfo* FileVersionInfo::CreateFileVersionInfo(
     const FilePath& file_path) {
   base::ThreadRestrictions::AssertIOAllowed();
 
   DWORD dummy;
@@ skipping 125 matching lines @@
   return false;
 }
 
 std::wstring FileVersionInfoWin::GetStringValue(const wchar_t* name) {
   std::wstring str;
   if (GetValue(name, &str))
     return str;
   else
     return L"";
 }