Do not call EC programmer shutdown functions explicitly.

internal.c

 /*
  * This file is part of the flashrom project.
  *
  * Copyright (C) 2009 Carl-Daniel Hailfinger
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 2 of the License, or
  * (at your option) any later version.
  *
@@ skipping 220 matching lines @@
                         free(arg);
                         return 1;
                 }
 
                 free(arg);
         } else {
                 /* The pacc must be initialized before access pci devices. */
                 probe_target_bus_later = 1;
         }
 
+        register_shutdown(internal_shutdown, NULL);

[Louis, 2011/04/26 10:06:06]

remove this if we restore the shutdown function in the programmer_table[] in
flashrom.c

[dhendrix, 2011/04/27 02:08:06]

The idea is to no longer rely on programmer_table[].shutdown, since it can only
apply to a single programmer.

         get_io_perms();
 
 #if defined(__i386__) || defined(__x86_64__)
         /* Initialize PCI access for flash enables */
         pacc = pci_alloc();     /* Get the pci_access structure */
         pacc->error = pci_error;
         pacc->warning = pci_warning;
         pacc->debug = pci_debug;
 
         /* Set all options you want -- here we stick with the defaults */
@@ skipping 113 matching lines @@
          */
         msg_perr("Your platform is not supported yet for the internal "
                  "programmer because it has\n"
                  "not been converted from native endian to little endian "
                  "access yet.\n"
                  "Aborting.\n");
         return 1;
 #endif
 }
 
-int internal_shutdown(void)
+void internal_shutdown(void *data)
 {
         release_io_perms();
-
-#if defined(__i386__) || defined(__x86_64__)
-        if (target_bus == CHIP_BUSTYPE_LPC ||
-            target_bus == CHIP_BUSTYPE_FWH) {
-                it85xx_shutdown();
-                wpce775x_shutdown();
-                mec1308_shutdown();
-        }
-#endif
-
-        return 0;
 }
 #endif
 
 void internal_chip_writeb(uint8_t val, chipaddr addr)
 {
         mmio_writeb(val, (void *) addr);
 }
 
 void internal_chip_writew(uint16_t val, chipaddr addr)
 {
@@ skipping 18 matching lines @@
 uint32_t internal_chip_readl(const chipaddr addr)
 {
         return mmio_readl((void *) addr);
 }
 
 void internal_chip_readn(uint8_t *buf, const chipaddr addr, size_t len)
 {
         memcpy(buf, (void *)addr, len);
         return;
 }