Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tests/presubmit_unittest.py

Issue 6897005: presubmit_support: cache the result of ChangedContents. (Closed) Base URL: http://src.chromium.org/svn/trunk/tools/depot_tools/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « presubmit_support.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/presubmit_unittest.py
===================================================================
--- tests/presubmit_unittest.py (revision 82763)
+++ tests/presubmit_unittest.py (working copy)
@@ -1219,8 +1219,14 @@
self.failUnless(af.LocalPath() == presubmit.normpath('foo/blat.cc'))
self.failUnless(af.Action() == 'M')
self.assertEquals(af.NewContents(), ['whatever', 'cookie'])
+
+ def testAffectedFileNotExists(self):
+ presubmit.os.path.exists('notfound.cc').AndReturn(False)
+ presubmit.gclient_utils.FileRead('notfound.cc', 'rU').AndRaise(IOError)
+ self.mox.ReplayAll()
af = presubmit.AffectedFile('notfound.cc', 'A')
self.failUnless(af.ServerPath() == '')
+ self.failUnless(af.NewContents() == [])
M-A Ruel 2011/04/27 14:07:43 nit: I prefer: self.assertEquals('', af.ServerPath
ncarter (slow) 2011/04/27 20:55:13 Done.
def testProperty(self):
presubmit.scm.SVN.GetFileProperty('foo.cc', 'svn:secret-property'
« no previous file with comments | « presubmit_support.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698