Issue 6897002: Use more than 9 arguments for ReplaceStringPlaceholders() in ntp_resource_cache.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6897002: Use more than 9 arguments for ReplaceStringPlaceholders() in ntp_resource_cache.cc (Closed)

Created:
9 years, 8 months ago by haraken1

Modified:
9 years, 6 months ago

Reviewers:
tony, commit-bot: I haz the power

CC:
chromium-reviews, Paweł Hajdan Jr., arv (Not doing code reviews), jshin+watch_chromium.org, brettw-cc_chromium.org

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Use more than 9 arguments for ReplaceStringPlaceholders() in ntp_resource_cache.cc See also http://codereview.chromium.org/149741/ BUG=16963 TEST=Observe that the theme image is tiled on a new tab page. Observe that all variables are replaced to their values in chrome://theme/css/newtab.css, i.e. the newtab.css contains no variables like "$$1" or "$$$1". Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88386

Patch Set 1 #

Patch Set 2 : Merge with issue 6877008 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -54 lines)			Patch
M	chrome/browser/resources/new_tab_theme.css	View		7 chunks	+17 lines, -17 lines	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab_theme.css	View	1	6 chunks	+13 lines, -13 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/ntp_resource_cache.cc	View	1	3 chunks	+15 lines, -24 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tony

Let's do the string_util changes separately (as part of http://codereview.chromium.org/6877008/) and once that is committed, ...

9 years, 8 months ago (2011-04-21 21:56:05 UTC) #2

haraken1

I fixed the bug 16963, based on CL 6877008. Would you please take a look?

9 years, 6 months ago (2011-06-08 00:31:46 UTC) #3

Change committed as 88386

Expand Messages | Collapse Messages