added md5_unittest

base/md5_unittest.cc

Index: base/md5_unittest.cc
diff --git a/base/md5_unittest.cc b/base/md5_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..81d44b5f347fb4dcb54eb9d5fd61852f0045bac5
--- /dev/null
+++ b/base/md5_unittest.cc
@@ -0,0 +1,115 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.

[Mark Mentovai, 2011/04/22 03:13:29]

In addition to the test data that you have, I’d like to see a test that
exercises the RFC 1321 MD5 test suite.

http://www.ietf.org/rfc/rfc1321.txt section A.5

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <string>
+
+#include "base/logging.h"
+#include "base/md5.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using namespace std;

[Mark Mentovai, 2011/04/22 03:13:29]

This is forbidden.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Namesp...

+
+TEST(MD5, EmtpyString) {
+  MD5Digest digest;
+  const char* data = "";
+
+  MD5Sum(data, strlen(data), &digest);

[Mark Mentovai, 2011/04/22 03:13:29]

#include <string.h>.

Alternatively, #include "base/basictypes.h" and use arraysize(data) - 1.

(arraysize(data) would be 1 in this case because "" contains a single NUL
terminator byte.

+
+  string expected = "d41d8cd98f00b204e9800998ecf8427e";
+  string actual = MD5DigestToBase16(digest);

[Mark Mentovai, 2011/04/22 03:13:29]

All of your tests run “actual” through MD5DigestToBase16. I’d like to see
testing of just the raw MD5Digest bytes. See sha1_unittest.cc for an example.

You don’t necessarily need to check the MD5Bytes each and every time. I’d be
satisfied with a single test that verified that an MD5Bytes struct is turned
into the expected string after a call to MD5DigestToBase16. You could call this
the test of MD5DigestToBase16 and leave the rest of the tests you’ve written
alone.

+
+  EXPECT_EQ(expected, actual);
+}
+
+TEST(MD5, OneByteStrnig) {

[Mark Mentovai, 2011/04/22 03:13:29]

Typo: OneByteString.

+  MD5Digest digest;
+  const char* data = "a";
+
+  MD5Sum(data, strlen(data), &digest);
+
+  string expected = "0cc175b9c0f1b6a831c399e269772661";
+  string actual = MD5DigestToBase16(digest);
+
+  EXPECT_EQ(expected, actual);
+}
+
+TEST(MD5, ShortString) {
+  MD5Digest digest;
+  const char* data = "The quick brown fox jumps over the lazy dog";
+
+  MD5Sum(data, strlen(data), &digest);
+
+  string expected = "9e107d9d372bb6826bd81d3542a419d6";
+  string actual = MD5DigestToBase16(digest);
+
+  EXPECT_EQ(expected, actual);
+}
+
+TEST(MD5, LongString) {
+  MD5Digest digest;
+
+  const int N = 10 * 1024 * 1024 + 1;

[Mark Mentovai, 2011/04/22 03:13:29]

N is a bad name for a variable. Also below on line 86.

+  char* data = new char[N];
+
+  for (int i = 0; i < N; ++i) {
+    data[i] = i & 0xFF;
+  }
+
+  MD5Sum(data, N, &digest);
+
+  string expected = "90bd6ad90acef5adaa92203e21c7a13e";
+  string actual = MD5DigestToBase16(digest);
+
+  EXPECT_EQ(expected, actual);
+
+  delete[] data;
+}
+
+TEST(MD5, ContextWithEmptyData) {
+  MD5Context ctx;
+  MD5Init(&ctx);
+
+  MD5Digest digest;
+  MD5Final(&digest, &ctx);
+
+  string expected = "d41d8cd98f00b204e9800998ecf8427e";
+  string actual = MD5DigestToBase16(digest);
+
+  EXPECT_EQ(expected, actual);
+}
+
+TEST(MD5, ContextWithLongData) {
+  MD5Context ctx;
+  MD5Init(&ctx);
+
+  const int N = 10 * 1024 * 1024 + 1;
+  char* data = new char[N];
+
+  for (int i = 0; i < N; ++i) {
+    data[i] = i & 0xFF;
+  }
+
+  int totalLen = 0;

[Mark Mentovai, 2011/04/22 03:13:29]

Variables are named like_this and not likeThis.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Variab...

+  while (totalLen < N) {
+    int len = 4097; // intentionally not 2^k.

[Mark Mentovai, 2011/04/22 03:13:29]

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Implem...

+    if (len > N - totalLen) {
+      len = N - totalLen;
+    }
+
+    MD5Update(&ctx, data + totalLen, len);
+    totalLen += len;
+  }
+
+  DCHECK_EQ(totalLen, N);

[Mark Mentovai, 2011/04/22 03:13:29]

EXPECT_EQ(N, total_length)?

+
+  MD5Digest digest;
+  MD5Final(&digest, &ctx);
+
+  string expected = "90bd6ad90acef5adaa92203e21c7a13e";
+  string actual = MD5DigestToBase16(digest);
+
+  EXPECT_EQ(expected, actual);
+
+  delete[] data;
+}

[Mark Mentovai, 2011/04/22 03:13:29]

No test of MD5String?