Issue 6894043: Crankshaft support for IN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6894043: Crankshaft support for IN. (Closed)

Created:
9 years, 8 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Crankshaft support for IN. In JavaScriptFrame::Print avoid printing optimized frame as if it is unoptimized. Committed: http://code.google.com/p/v8/source/detail?r=7682

Patch Set 1 #

Total comments: 2

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+172 lines, -1 line)			Patch
M	src/arm/lithium-arm.h	View	2 chunks	+15 lines, -0 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	2 chunks	+18 lines, -0 lines	0 comments	Download
M	src/frames.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen-instructions.h	View	2 chunks	+23 lines, -0 lines	1 comment	Download
M	src/hydrogen-instructions.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+29 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View	2 chunks	+15 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 chunk	+8 lines, -0 lines	1 comment	Download
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	src/x64/lithium-x64.h	View	2 chunks	+15 lines, -0 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

fschneider

9 years, 8 months ago (2011-04-26 13:51:59 UTC) #2

LGTM with comments.

http://codereview.chromium.org/6894043/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

http://codereview.chromium.org/6894043/diff/1/src/hydrogen-instructions.h#new...
src/hydrogen-instructions.h:3800: 
You should override CalculateInferredType to return Boolean.

http://codereview.chromium.org/6894043/diff/1/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):

http://codereview.chromium.org/6894043/diff/1/src/ia32/lithium-ia32.cc#newcod...
src/ia32/lithium-ia32.cc:2209: LOperand* key = UseAtStart(instr->key());
Use UseOrConstantAtStart here. The same possibly also for other platforms.

Expand Messages | Collapse Messages