Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: chrome/browser/ui/gtk/about_chrome_dialog.cc

Issue 6894037: Add more information to about:version and "About Chromium" dialog (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Use ScopedAllowIO and directly call AbsolutePath() Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/about_chrome_dialog.cc
diff --git a/chrome/browser/ui/gtk/about_chrome_dialog.cc b/chrome/browser/ui/gtk/about_chrome_dialog.cc
index c00e83fc34fb3fa603cfee559cf0547698e9596a..1ca1d02d6391dc8926a90d34f75ea79ba46e2cee 100644
--- a/chrome/browser/ui/gtk/about_chrome_dialog.cc
+++ b/chrome/browser/ui/gtk/about_chrome_dialog.cc
@@ -106,7 +106,13 @@ void ShowAboutDialogForProfile(GtkWindow* parent, Profile* profile) {
std::string current_version = version_info.Version();
#if !defined(GOOGLE_CHROME_BUILD)
current_version += " (";
+ current_version += l10n_util::GetStringUTF8(
+ version_info.IsOfficialBuild() ?
+ IDS_ABOUT_VERSION_OFFICIAL : IDS_ABOUT_VERSION_UNOFFICIAL);
+ current_version += " ";
current_version += version_info.LastChange();
+ current_version += " ";
+ current_version += version_info.OSType();
current_version += ")";
#endif
std::string channel = platform_util::GetVersionStringModifier();

Powered by Google App Engine
This is Rietveld 408576698