chrome/browser/ui/gtk/about_chrome_dialog.cc - Issue 6894037: Add more information to about:version and "About Chromium" dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/about_chrome_dialog.cc

Issue 6894037: Add more information to about:version and "About Chromium" dialog (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Delete "webkit_name" and "js_name" and misc Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/browser_about_handler.cc ('K') | « chrome/browser/resources/about_version.html ('k') | chrome/browser/ui/views/about_chrome_view.h » ('j') | chrome/common/chrome_version_info.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/about_chrome_dialog.cc

diff --git a/chrome/browser/ui/gtk/about_chrome_dialog.cc b/chrome/browser/ui/gtk/about_chrome_dialog.cc

index c00e83fc34fb3fa603cfee559cf0547698e9596a..1ca1d02d6391dc8926a90d34f75ea79ba46e2cee 100644

--- a/chrome/browser/ui/gtk/about_chrome_dialog.cc

+++ b/chrome/browser/ui/gtk/about_chrome_dialog.cc

@@ -106,7 +106,13 @@ void ShowAboutDialogForProfile(GtkWindow* parent, Profile* profile) {

std::string current_version = version_info.Version();

#if !defined(GOOGLE_CHROME_BUILD)

current_version += " (";

+ current_version += l10n_util::GetStringUTF8(

+ version_info.IsOfficialBuild() ?

+ IDS_ABOUT_VERSION_OFFICIAL : IDS_ABOUT_VERSION_UNOFFICIAL);

+ current_version += " ";

current_version += version_info.LastChange();

+ current_version += " ";

+ current_version += version_info.OSType();

current_version += ")";

#endif

std::string channel = platform_util::GetVersionStringModifier();