Add more information to about:version and "About Chromium" dialog

chrome/common/chrome_version_info.cc

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_version_info.h"
 
 #include "base/basictypes.h"
 #include "base/file_version_info.h"
 #include "base/string_util.h"
+#include "ui/base/l10n/l10n_util.h"
 #include "base/threading/thread_restrictions.h"
 #include "build/build_config.h"
 
 namespace chrome {
 
 #if defined(OS_WIN) || defined(OS_MACOSX)
 // On Windows and Mac, we get the Chrome version info by querying
 // FileVersionInfo for the current module.
 
 VersionInfo::VersionInfo() {
@@ skipping 60 matching lines @@
 std::string VersionInfo::LastChange() const {
   return LAST_CHANGE;
 }
 
 bool VersionInfo::IsOfficialBuild() const {
   return OFFICIAL_BUILD;
 }
 
 #endif
 
+std::string VersionInfo::OSType() const {
+#if defined(OS_MACOSX)
+  return "Mac OS";
+#elif defined(OS_NACL)
+  return "Native Client";

[Evan Martin, 2011/04/22 22:36:41]

I don't think this actually counts as an OS here.

+#elif defined(OS_LINUX)
+  return "Linux";
+#elif defined(OS_WIN)
+  return "Windows";

[Evan Martin, 2011/04/22 22:36:41]

Can you put this one first?  (We usually do Win/Mac/Linux in that order in this
kind of code.)

+#elif defined(OS_FREEBSD)
+  return "FreeBSD";
+#elif defined(OS_OPENBSD)
+  return "OpenBSD";
+#elif defined(OS_SOLARIS)
+  return "Solaris";
+#elif defined(OS_CHROMEOS)
+  return l10n_util::GetStringUTF16(IDS_PRODUCT_OS_NAME);
+#else
+  return "Unknown";
+#endif
+}
+
 }  // namespace chrome