Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5469)

Unified Diff: chrome/browser/prefs/pref_service.h

Issue 6894020: Adds async interface method to PersistentPrefStore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: always call OnInit.. Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/pref_service.h
diff --git a/chrome/browser/prefs/pref_service.h b/chrome/browser/prefs/pref_service.h
index f9d415f3ec3e9567b575c9bdedc0d1d0ce587b5a..8e5405f3e7572becde3ccba26e58bf9a416b03e3 100644
--- a/chrome/browser/prefs/pref_service.h
+++ b/chrome/browser/prefs/pref_service.h
@@ -41,7 +41,7 @@ class PrefServiceDelegate {
};
class PrefService : public base::NonThreadSafe,
- public JsonPrefStore::Delegate {
+ public PrefStore::Observer {
public:
// A helper class to store all the information associated with a preference.
class Preference {
@@ -120,10 +120,6 @@ class PrefService : public base::NonThreadSafe,
DISALLOW_COPY_AND_ASSIGN(Preference);
};
- // JsonPrefStore::Delegate implementaion.
- virtual void OnPrefsRead(PersistentPrefStore::PrefReadError error,
- bool no_dir);
-
// Factory method that creates a new instance of a PrefService with the
// applicable PrefStores. The |pref_filename| points to the user preference
// file. The |profile| is the one to which these preferences apply; it may be
@@ -263,6 +259,10 @@ class PrefService : public base::NonThreadSafe,
DefaultPrefStore* default_store,
PrefServiceDelegate* delegate);
+ // PrefStore::Observer implementation:
+ virtual void OnPrefValueChanged(const std::string&) {}
+ virtual void OnInitializationCompleted();
+
// The PrefNotifier handles registering and notifying preference observers.
// It is created and owned by this PrefService. Subclasses may access it for
// unit testing.

Powered by Google App Engine
This is Rietveld 408576698