Adds async interface method to PersistentPrefStore.

chrome/browser/prefs/pref_notifier_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/pref_notifier_impl.h"
 
 #include "base/stl_util-inl.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "content/common/notification_observer.h"
 #include "content/common/notification_service.h"
@@ skipping 57 matching lines @@
 
   NotificationObserverList* observer_list = observer_iterator->second;
   observer_list->RemoveObserver(obs);
 }
 
 void PrefNotifierImpl::OnPreferenceChanged(const std::string& path) {
   FireObservers(path);
 }
 
 void PrefNotifierImpl::OnInitializationCompleted() {
+  pref_notifier_ready_ = true;
+  NotifyInitializationCompleted();
+}
+
+void PrefNotifierImpl::OnPersistentPrefsRead(bool success) {

[Mattias Nissler (ping if slow), 2011/04/27 12:16:30]

We should really get this trigger through OnInitializationCompleted(). If you
need a status code, I suggest adding an enum to PrefNotifier that you can pass
as a  parameter.

Once you have done so, you also don't need the ready_ flag, since PrefValueStore
can make sure to call OnInitializationCompleted only once.

[altimofeev, 2011/05/04 13:46:14]

Done.

+  if (!success) {
+    NotifyInitializationFailed();
+    return;
+  }
+  persistent_prefs_ready_ = true;
+  NotifyInitializationCompleted();
+}
+
+void PrefNotifierImpl::NotifyInitializationCompleted() {
+  if (!pref_notifier_ready_ || !persistent_prefs_ready_)
+    return;
+
   DCHECK(CalledOnValidThread());
-
   NotificationService::current()->Notify(
       NotificationType::PREF_INITIALIZATION_COMPLETED,
       Source<PrefService>(pref_service_),
       NotificationService::NoDetails());
 }
 
+void PrefNotifierImpl::NotifyInitializationFailed() {

[Mattias Nissler (ping if slow), 2011/04/27 12:16:30]

We shouldn't have a second notification, but rather a Details parameter for the
PREF_INITIALIZATION_COMPLETED notification that indicates the status.

[altimofeev, 2011/05/04 13:46:14]

Done.

+  DCHECK(CalledOnValidThread());
+  NotificationService::current()->Notify(
+      NotificationType::PREF_INITIALIZATION_FAILED,
+      Source<PrefService>(pref_service_),
+      NotificationService::NoDetails());
+}
+
 void PrefNotifierImpl::FireObservers(const std::string& path) {
   DCHECK(CalledOnValidThread());
 
   // Only send notifications for registered preferences.
   if (!pref_service_->FindPreference(path.c_str()))
     return;
 
   const PrefObserverMap::iterator observer_iterator =
       pref_observers_.find(path);
   if (observer_iterator == pref_observers_.end())
     return;
 
   NotificationObserverList::Iterator it(*(observer_iterator->second));
   NotificationObserver* observer;
   while ((observer = it.GetNext()) != NULL) {
     observer->Observe(NotificationType::PREF_CHANGED,
                       Source<PrefService>(pref_service_),
                       Details<const std::string>(&path));
   }
 }