Adds async interface method to PersistentPrefStore.

chrome/browser/prefs/pref_notifier_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/pref_notifier_impl.h"
 
 #include "base/stl_util-inl.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "content/common/notification_observer.h"
 #include "content/common/notification_service.h"
@@ skipping 56 matching lines @@
   }
 
   NotificationObserverList* observer_list = observer_iterator->second;
   observer_list->RemoveObserver(obs);
 }
 
 void PrefNotifierImpl::OnPreferenceChanged(const std::string& path) {
   FireObservers(path);
 }
 
-void PrefNotifierImpl::OnInitializationCompleted() {
+void PrefNotifierImpl::OnInitializationCompleted(bool succeeded) {
   DCHECK(CalledOnValidThread());
 
   NotificationService::current()->Notify(
       NotificationType::PREF_INITIALIZATION_COMPLETED,
       Source<PrefService>(pref_service_),
-      NotificationService::NoDetails());
+      Details<PrefService>(succeeded ? pref_service_ : NULL));

[Mattias Nissler (ping if slow), 2011/05/04 23:33:08]

That's a weird contract. Why not have an enum and use
Details<PrefService::InitializationStatus> here?

[altimofeev, 2011/05/05 12:59:28]

I mistakenly thought that detail's pointer should outlive function end. Since it
is not the case, I think Details<bool> will be sufficient.

 }
 
 void PrefNotifierImpl::FireObservers(const std::string& path) {
   DCHECK(CalledOnValidThread());
 
   // Only send notifications for registered preferences.
   if (!pref_service_->FindPreference(path.c_str()))
     return;
 
   const PrefObserverMap::iterator observer_iterator =
       pref_observers_.find(path);
   if (observer_iterator == pref_observers_.end())
     return;
 
   NotificationObserverList::Iterator it(*(observer_iterator->second));
   NotificationObserver* observer;
   while ((observer = it.GetNext()) != NULL) {
     observer->Observe(NotificationType::PREF_CHANGED,
                       Source<PrefService>(pref_service_),
                       Details<const std::string>(&path));
   }
 }