Check the ibus version in build script.

Check the ibus version in build script.

Patch by Peng Huang <penghuang@chromium.org>;

BUG=chromium:80972
TEST=Linux desktop
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83758

[agl, 2011-04-29 14:37:44]

LGTM but Paweł probably knows more about pkg-config than I do.

[Yusuke Sato, 2011-04-29 14:37:45]

LGTM

On 2011/04/29 14:33:34, Peng wrote:

[Paweł Hajdan Jr., 2011-04-29 14:45:04]

Surprisingly I don't know _that_ much about pkg-config either. Generally looks
good, nice change.

I'm removing myself from reviewers and instead adding Mark - I'm not sure
whether the ibus_version variable is the best solution (rather nit-like
concern).

[Peng, 2011-04-29 21:12:09]

Hi Mark, Do you think this CL is OK?

Thanks.

On 2011/04/29 14:45:04, Paweł Hajdan Jr. wrote:
> Surprisingly I don't know _that_ much about pkg-config either. Generally looks
> good, nice change.
> 
> I'm removing myself from reviewers and instead adding Mark - I'm not sure
> whether the ibus_version variable is the best solution (rather nit-like
> concern).

[Mark Mentovai, 2011-05-02 16:08:56]

I think this is LGTM, but can you explain (1) what the >= syntax does to
pkg-config, (2) why we want to do this, and (3) what the significance of that
version number is?

I can look (1) up myself, I’m most interested in the answer to (2) and (3).

[Peng, 2011-05-02 16:26:24]

On 2011/05/02 16:08:56, Mark Mentovai wrote:
> I think this is LGTM, but can you explain (1) what the >= syntax does to
> pkg-config, (2) why we want to do this, and (3) what the significance of that
> version number is?
> 
> I can look (1) up myself, I’m most interested in the answer to (2) and (3).

(1):
http://linux.die.net/man/1/pkg-config

--atleast-version=VERSION
--exact-version=VERSION
--max-version=VERSION
These options test whether the package or list of packages on the command line
are known to pkg-config, and optionally whether the version number of a package
meets certain contraints. If all packages exist and meet the specified version
constraints, pkg-config exits successfully. Otherwise it exits unsuccessfully.
Rather than using the version-test options, you can simply give a version
constraint after each package name, for example:

$ pkg-config --exists 'glib-2.0 >= 1.3.4 libxml = 1.8.3'

(2) Because chromeos-chrome can only compile with ibus-1.3.99.20110425 or later.
And default ibus in Ubunut is 1.3.9.

(3) With this change, if the ibus version is lower than expect, the build error
will happen in `gclient runhooks` instead of compiling. And it could also give
some error message like:
$ pkg-config --cflags "ibus-1.0 >= 1.3.99.20110425"
Requested 'ibus-1.0 >= 1.3.99.20110425' but version of IBus is 1.3.99.20110420

The message can help developer to figure out what is the problem.

[commit-bot: I haz the power, 2011-05-02 17:36:30]

Presubmit check for 6893129-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  build/linux/system.gyp, line 382, 97 chars

[Mark Mentovai, 2011-05-02 17:51:39]

LGTM. Thanks for the explanation.

http://codereview.chromium.org/6893129/diff/1/build/linux/system.gyp
File build/linux/system.gyp (right):

http://codereview.chromium.org/6893129/diff/1/build/linux/system.gyp#newcode355
build/linux/system.gyp:355: 'ibus_version': '1.3.99.20110425',
ibus_version sounds like it’s the version of ibus in use. Maybe call this
ibus_min_version.

[Peng, 2011-05-02 18:12:29]

http://codereview.chromium.org/6893129/diff/1/build/linux/system.gyp
File build/linux/system.gyp (right):

http://codereview.chromium.org/6893129/diff/1/build/linux/system.gyp#newcode355
build/linux/system.gyp:355: 'ibus_version': '1.3.99.20110425',
On 2011/05/02 17:51:39, Mark Mentovai wrote:
> ibus_version sounds like it’s the version of ibus in use. Maybe call this
> ibus_min_version.

Done.

[Peng, 2011-05-02 18:16:17]

On 2011/05/02 17:36:30, commit-bot wrote:
> Presubmit check for 6893129-1 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit Warnings **
> Found lines longer than 80 characters (first 5 shown).
>   build/linux/system.gyp, line 382, 97 chars

I found there are several lines are longer than 80 characters in gyp files. So
should I fix it or just waive it? How to do it with commit-bot?

[commit-bot: I haz the power, 2011-05-02 18:20:44]

Presubmit check for 6893129-5003 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  build/linux/system.gyp, line 382, 101 chars \
  build/linux/system.gyp, line 385, 83 chars

[Mark Mentovai, 2011-05-02 18:54:12]

If you have commit access, you can commit this with the command-line
tools, bypassing the commit queue. Just tell it “--no_presubmit”.

[Peng, 2011-05-02 19:14:26]

I don't have. :(
Could you help me do it? Thanks.

On 2011/05/02 18:54:12, Mark Mentovai wrote:
> If you have commit access, you can commit this with the command-line
> tools, bypassing the commit queue. Just tell it “--no_presubmit”.

[Mark Mentovai, 2011-05-02 19:26:52]

Checked in at r83758.