Issue 6893111: Enhancements to ktop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6893111: Enhancements to ktop (Closed)

Created:
9 years, 8 months ago by Paul T

Modified:
9 years, 6 months ago

Reviewers:
Mandeep Singh Baines, Luigi Semenzato, ups

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://gitrw.chromium.org:9222/ktop.git@master

Visibility:
Public.

Enhancements to ktop A number of enhancements that I'd made to ktop while working on getting ktop into the developer environment. 1. Split the display into multiple screens 2. Average duration of system calls 3. File system calls broken out BUG=13360 TEST=built using gmerge and ran on cr48 Change-Id: I465692365892716b0473610245ee1d7414dc0337 R=msb@chromium.org,semenzato@chromium.org,ups@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=06bee5b

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1197 lines, -358 lines)			Patch
M	Makefile	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	collector.h	View	1 chunk	+58 lines, -0 lines	0 comments	Download
M	collector.c	View	11 chunks	+136 lines, -229 lines	0 comments	Download
A	debug.h	View	1 chunk	+85 lines, -0 lines	0 comments	Download
A	debug.c	View	1 chunk	+303 lines, -0 lines	0 comments	Download
M	display.c	View	5 chunks	+127 lines, -99 lines	0 comments	Download
A	dump.c	View	1 chunk	+160 lines, -0 lines	0 comments	Download
M	gnu.mk	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ktop.h	View	3 chunks	+41 lines, -13 lines	0 comments	Download
M	main.c	View	6 chunks	+30 lines, -6 lines	0 comments	Download
A	mylib.h	View	1 chunk	+65 lines, -0 lines	0 comments	Download
M	plot.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	plot.c	View	1 chunk	+1 line, -1 line	0 comments	Download
A	reduce.h	View	1 chunk	+37 lines, -0 lines	0 comments	Download
A	reduce.c	View	1 chunk	+146 lines, -0 lines	0 comments	Download
M	syscall.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tickcounter.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tickcounter.c	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

Mandeep Singh Baines

9 years, 7 months ago (2011-04-29 16:55:18 UTC) #2

LGTM

But next time please break up into individual commits.