Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 6893095: Don't eat newlines in CL descriptions when merging changes using drover. (Closed)

Created:
9 years, 7 months ago by Robert Sesek
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Don't eat newlines in CL descriptions when merging changes using drover. BUG=80589 TEST=Merge a CL using drover and when prompted to upload, check that the original CL description still has its linebreaks. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83561

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M drover.py View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Robert Sesek
9 years, 7 months ago (2011-04-28 16:16:31 UTC) #1
M-A Ruel
http://codereview.chromium.org/6893095/diff/1/drover.py File drover.py (right): http://codereview.chromium.org/6893095/diff/1/drover.py#newcode121 drover.py:121: ['svn', 'log', url, '-r', str(revision)]).splitlines() Replace this whole function ...
9 years, 7 months ago (2011-04-29 18:29:17 UTC) #2
Robert Sesek
http://codereview.chromium.org/6893095/diff/1/drover.py File drover.py (right): http://codereview.chromium.org/6893095/diff/1/drover.py#newcode121 drover.py:121: ['svn', 'log', url, '-r', str(revision)]).splitlines() On 2011/04/29 18:29:17, Marc-Antoine ...
9 years, 7 months ago (2011-04-29 18:38:41 UTC) #3
M-A Ruel
9 years, 7 months ago (2011-04-29 18:39:20 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698